Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add bypass prod string in alias check #174

Closed
ekristen opened this issue May 18, 2024 · 4 comments
Closed

feature: add bypass prod string in alias check #174

ekristen opened this issue May 18, 2024 · 4 comments

Comments

@ekristen
Copy link
Owner

There are a few options here.

  1. allow overriding all "strings" that are in the alias, i.e. people might use live vs prod and might want to prevent running against those.
  2. allow bypassing this check, possibly implement like bypass alias check https://ekristen.github.io/aws-nuke/features/bypass-alias-check/
@ekristen
Copy link
Owner Author

Hi @jasonwbarnett I'm pinging you here because I'm managing a breakaway fork that I've been rewriting and updating to make it easier for contributions. I'm doubtful that rebuy-de/aws-nuke#1224 will get merged. It's happened before, but I'm open to implementing on this version of aws-nuke.

I have a feature for bypassing alias checks. I think I would want to implement it similar. Require the account ID to be in a configuration block, and pass a CLI flag, that way it makes it a conscious choice not something likely done on accident.

@ekristen ekristen changed the title feature: add bypass prod string alias check feature: add bypass prod string in alias check May 18, 2024
@ekristen
Copy link
Owner Author

@jasonwbarnett I was reviewing the code this weekend and the bypass alias check feature I already added will allow you to bypass the prod substring check as well, although I wonder if this shouldn't be a separate feature.

@ekristen ekristen closed this as completed Jun 4, 2024
@jasonwbarnett
Copy link

In what PR was this completed?

@ekristen
Copy link
Owner Author

@jasonwbarnett at the moment this feature currently allows for bypassing anything alias related including strings like prod https://ekristen.github.io/aws-nuke/features/bypass-alias-check/

This feature allows you to bypass all alias checks by configuring the account in the yaml and by providing a cli switch.

If you are interested in having a custom list of strings to block for the alias please let me know and we can open an issue to track that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants