-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add bypass prod string in alias check #174
Comments
Hi @jasonwbarnett I'm pinging you here because I'm managing a breakaway fork that I've been rewriting and updating to make it easier for contributions. I'm doubtful that rebuy-de/aws-nuke#1224 will get merged. It's happened before, but I'm open to implementing on this version of aws-nuke. I have a feature for bypassing alias checks. I think I would want to implement it similar. Require the account ID to be in a configuration block, and pass a CLI flag, that way it makes it a conscious choice not something likely done on accident. |
@jasonwbarnett I was reviewing the code this weekend and the bypass alias check feature I already added will allow you to bypass the prod substring check as well, although I wonder if this shouldn't be a separate feature. |
In what PR was this completed? |
@jasonwbarnett at the moment this feature currently allows for bypassing anything alias related including strings like This feature allows you to bypass all alias checks by configuring the account in the yaml and by providing a cli switch. If you are interested in having a custom list of strings to block for the alias please let me know and we can open an issue to track that. |
There are a few options here.
live
vsprod
and might want to prevent running against those.The text was updated successfully, but these errors were encountered: