Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should "--override-existing-serviceaccounts" be an default behavior? #1698

Closed
M00nF1sh opened this issue Jan 4, 2020 · 6 comments
Closed
Labels
kind/feature New feature or request

Comments

@M00nF1sh
Copy link
Contributor

M00nF1sh commented Jan 4, 2020

Before creating a feature request, please search existing feature requests to see if you find a similar one. If there is a similar feature request please up-vote it and/or add your comments to it instead

Why do you want this feature?
I feel like the service-account for applications should be create along with the application. (e.g. embed in application's yamls which included SA/rbac roles/deployments/etc.)
EKSCTL's eksctl create iamserviceaccount should ideally only create an iam role and annotate existing SA with the role.....(which merely attach eks-specific behavior to a cloud-neutral k8s application)

What feature/behavior/change do you want?
make --override-existing-serviceaccounts an default behavior, or another command?

Do not hesitate, when appropriate, to share the exact commands or API you would like, and/or to share a diagram (e.g.: asciiflow.com): "a picture is worth a thousand words".

@M00nF1sh M00nF1sh added the kind/feature New feature or request label Jan 4, 2020
@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the stale label Jan 18, 2021
@michaelbeaumont
Copy link
Contributor

@aclevername You've been doing a lot of iamserviceaccount changes with #1497, wdyt?

@michaelbeaumont
Copy link
Contributor

Relevant for #2774

@aclevername
Copy link
Contributor

#3042 seems quite similar to this. Seems to be a varying of opinion on what should happen regarding service accounts. I outlined in a comment my thoughts on having the ability to skip service account creation/annotation. I think its a good idea, particularly in the context of a gitops setup combined with the roleName field for IAMServiceAccounts

@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@michaelbeaumont
Copy link
Contributor

Closing, won't be changed until #2774

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants