Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No schema check for the property "attachPolicyARNs" #2682

Closed
hassanSRE opened this issue Sep 26, 2020 · 1 comment
Closed

No schema check for the property "attachPolicyARNs" #2682

hassanSRE opened this issue Sep 26, 2020 · 1 comment
Labels

Comments

@hassanSRE
Copy link

What happened?
When creating a simple config file to create a nodegroup that includes the property attachPolicyARNs, if the attach policy arn property is not written exactly like "attachPolicyARNs:", it is ignore. Example:

---
apiVersion: eksctl.io/v1alpha5
kind: ClusterConfig

metadata:
  name: cluster-name
  region: ap-southeast-2

nodeGroups:
  - name: ng-name
    iam:
      attachPolicyARNs:
        - arn:aws:iam::aws:policy/AmazonEKSWorkerNodePolicy
        - arn:aws:iam::aws:policy/AmazonEKS_CNI_Policy
        - arn:aws:iam::ACCOUNT:policy/SOME_POLICY

The above will be ignored and all 3 default node policies will be added instead
Note the above property attachPolicyArns isn't exactly the same as attachPolicyARNs. Changing the above property to the exact described schema attachPolicyARNs works fine

What you expected to happen?
If the property attachPolicyARNs added is not adhering to the case sensitivity, it should throw a schema validation error instead of just ignoring it

How to reproduce it?
Add the following in the config schema:
nodeGroups:

  • name: ng-name
    ...
    iam:
    attachPolicyArns: ## <----- Note that this isn't exactly like attachPolicyARNs
    - arn:aws:iam::aws:policy/AmazonEKSWorkerNodePolicy
    - arn:aws:iam::aws:policy/AmazonEKS_CNI_Policy
    - arn:aws:iam::ACCOUNT:policy/NAME_OF_POLIC

Versions
Please paste in the output of these commands:

$ eksctl version 0.28.1
$ kubectl version v1.15.10-eks-bac369
@michaelbeaumont
Copy link
Contributor

michaelbeaumont commented Sep 28, 2020

Duplicate of #753

@michaelbeaumont michaelbeaumont marked this as a duplicate of #753 Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants