Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete missing nodegroups based on config file #664

Closed
errordeveloper opened this issue Mar 26, 2019 · 3 comments · Fixed by #714
Closed

delete missing nodegroups based on config file #664

errordeveloper opened this issue Mar 26, 2019 · 3 comments · Fixed by #714

Comments

@errordeveloper
Copy link
Contributor

This would improve upgrade docs.

@errordeveloper
Copy link
Contributor Author

errordeveloper commented Mar 27, 2019

With respect to the docs, right now this is what we suggest to the users

# collect old nodegroup names
old_nodegroups="$(eksctl get ng --cluster=<clusterName> --output=json | jq -r '.[].Name')"
# create new nodegroups based on config file
eksctl create nodegroup --config-file=<path> 
# delete old ones
for ng in $old_nodegroups ; do eksctl delete nodegroup --cluster=<clusterName> --name=$ng ; done

so the idea is to get rid of jq and the for loop

eksctl create nodegroup --config-file=<path> 
eksctl delete nodegroup --config-file=<path>  --only-missing

@errordeveloper
Copy link
Contributor Author

After some refactoring (#665, #670 & #671), we are ready to add --config-file and --only, so that eksctl delete ng matches eksctl create ng, and then we can add --only-missing as well.

@errordeveloper
Copy link
Contributor Author

See also #682.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant