Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceRole and NodeInstanceRole missing tags #750

Closed
cdenneen opened this issue Apr 24, 2019 · 7 comments
Closed

ServiceRole and NodeInstanceRole missing tags #750

cdenneen opened this issue Apr 24, 2019 · 7 comments

Comments

@cdenneen
Copy link

These roles are created (ServiceRole for cluster and NodeInstanceRole for the nodegroup) but neither has tags propagated to them.

@errordeveloper
Copy link
Contributor

This maybe down to CloudFormation, but needs looking into for sure.

@errordeveloper
Copy link
Contributor

So I just checked, and it appears that CloudFormation tags majority of the resources that we create, except for the aforementioned as well as EIP. I sort of recall looking into this a while back, it's one of those long-standing "bug".

Just checked the docs and neither AWS::EC2::EIP nor AWS::IAM::Role have Tags field exposed to CloudFormation...

@errordeveloper
Copy link
Contributor

#25 is related, but a different story - there the underlying API still doesn't support tags.

@ma-tty
Copy link

ma-tty commented Oct 1, 2019

AWS::IAM::Role has now Tags property exposed.

@whereisaaron
Copy link

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-iam-role.html#cfn-iam-role-tags

Type: AWS::IAM::Role
Properties: 
  AssumeRolePolicyDocument: Json
  Description: String
  ManagedPolicyArns: 
    - String
  MaxSessionDuration: Integer
  Path: String
  PermissionsBoundary: String
  Policies: 
    - Policy
  RoleName: String
  Tags: 
    - Tag

@jimsmith
Copy link

Hello,

Having deployed CF template using the IAM Roles 'tags' https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-iam-role.html#cfn-iam-role-tags

I have found that the !Ref is not being honored.

This below works when it's hardcoded

Tags:
        - 
          Key: "keyname1"
          Value: "value1"
        - 
          Key: "keyname2"
          Value: "value2"

This below is not working and the same Parameter works for EC2 and Lambda resources.

Tags:
        - Key: Application
          Value: !Ref 'Application'
        - Key: Application
          Value: !Ref 'Application'

@michaelbeaumont
Copy link
Contributor

Both the ServiceRole and NodeInstanceRole now have tags propagated to them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants