Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split CIDR consistently across different settings #7840

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Split CIDR consistently across different settings #7840

wants to merge 1 commit into from

Conversation

TiberiuGC
Copy link
Collaborator

Description

Fixes #7835

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@TiberiuGC TiberiuGC marked this pull request as ready for review June 19, 2024 06:47
@cPu1
Copy link
Collaborator

cPu1 commented Jun 21, 2024

Split IPv4 CIDR consistently across different settings

The commit message says IPv4 instead of IPv6.

@github-actions github-actions bot added the stale label Jul 22, 2024
@github-actions github-actions bot closed this Jul 27, 2024
@TiberiuGC TiberiuGC reopened this Jul 29, 2024
@github-actions github-actions bot removed the stale label Jul 30, 2024
@github-actions github-actions bot added the stale label Aug 29, 2024
@TiberiuGC TiberiuGC added priority/important-soon Ideally to be resolved in time for the next release and removed stale labels Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cPu1 cPu1 cPu1 approved these changes

Assignees
No one assigned
Labels
area/aws-vpc area/ipv6 kind/bug priority/important-soon Ideally to be resolved in time for the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Creating IPv6 Cluster on 2 or 4 AZs fails because of inconsistent CIDR partitioning
2 participants
@TiberiuGC @cPu1