Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Build fails with Go 1.24 #8209

Closed
stefanb opened this issue Feb 12, 2025 · 1 comment · Fixed by #8210
Closed

[Bug] Build fails with Go 1.24 #8209

stefanb opened this issue Feb 12, 2025 · 1 comment · Fixed by #8210
Labels
kind/bug

Comments

@stefanb
Copy link

stefanb commented Feb 12, 2025 •
edited
Loading

What were you trying to accomplish?

Build with Go 1.24

What happened?

Build failed with
internal error: package "fmt" without types was imported from "github.com/aws/aws-sdk-go/aws/client"

How to reproduce it?

  1. Install Go 1.24
  2. Build

Logs

Full build log from: https://github.com/Homebrew/homebrew-core/actions/runs/13269964591/job/37049618552#step:3:6636

  ==> make build
  Last 150 lines from /Users/brew/actions-runner/_work/homebrew-core/homebrew-core/bottles/logs/eksctl/01.make:
  go: downloading google.golang.org/api v0.152.0
  go: downloading github.com/mattn/go-ieproxy v0.0.1
  go: downloading github.com/kr/fs v0.1.0
  go: downloading golang.org/x/exp v0.0.0-20240103183307-be819d1f06fc
  go: downloading github.com/googleapis/gax-go/v2 v2.12.0
  go: downloading google.golang.org/genproto/googleapis/rpc v0.0.0-20231120223509-83a465c0220f
  go generate ./pkg/authconfigmap
  go generate ./pkg/awsapi/...
  + '[' 2 -eq 2 ']'
  + SERVICE_NAME=autoscaling
  + INTERFACE_NAME=ASG
  + PACKAGE_NAME=github.com/aws/aws-sdk-go-v2/service/autoscaling
  + go get github.com/aws/aws-sdk-go-v2/service/autoscaling
  go: downloading github.com/aws/aws-sdk-go-v2/service/autoscaling v1.51.12
  go: upgraded github.com/aws/aws-sdk-go-v2 v1.34.0 => v1.36.1
  go: upgraded github.com/aws/aws-sdk-go-v2/internal/configsources v1.3.29 => v1.3.32
  go: upgraded github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.6.29 => v2.6.32
  go: upgraded github.com/aws/aws-sdk-go-v2/service/autoscaling v1.51.8 => v1.51.12
  ++ go list -m -f '{{.Dir}}' github.com/aws/aws-sdk-go-v2/service/autoscaling
  + AWS_SDK_DIR=/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/aws/aws-sdk-go-v2/service/autoscaling@v1.51.12
  + /opt/homebrew/bin/ifacemaker -f '/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/aws/aws-sdk-go-v2/service/autoscaling@v1.51.12/*.go' -s Client -i ASG -p awsapi -y 'ASG provides an interface to the AWS ASG service.' -c 'Code generated by ifacemaker; DO NOT EDIT.' -m github.com/aws/aws-sdk-go-v2/service/autoscaling
  + '[' 2 -eq 2 ']'
  + SERVICE_NAME=cloudwatchlogs
  + INTERFACE_NAME=CloudWatchLogs
  + PACKAGE_NAME=github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs
  + go get github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs
  go: downloading github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs v1.45.12
  go: upgraded github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs v1.45.8 => v1.45.12
  ++ go list -m -f '{{.Dir}}' github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs
  + AWS_SDK_DIR=/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs@v1.45.12
  + /opt/homebrew/bin/ifacemaker -f '/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs@v1.45.12/*.go' -s Client -i CloudWatchLogs -p awsapi -y 'CloudWatchLogs provides an interface to the AWS CloudWatchLogs service.' -c 'Code generated by ifacemaker; DO NOT EDIT.' -m github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs
  + '[' 2 -eq 2 ']'
  + SERVICE_NAME=cloudformation
  + INTERFACE_NAME=CloudFormation
  + PACKAGE_NAME=github.com/aws/aws-sdk-go-v2/service/cloudformation
  + go get github.com/aws/aws-sdk-go-v2/service/cloudformation
  go: downloading github.com/aws/aws-sdk-go-v2/service/cloudformation v1.57.0
  go: upgraded github.com/aws/aws-sdk-go-v2/service/cloudformation v1.56.8 => v1.57.0
  ++ go list -m -f '{{.Dir}}' github.com/aws/aws-sdk-go-v2/service/cloudformation
  + AWS_SDK_DIR=/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/aws/aws-sdk-go-v2/service/cloudformation@v1.57.0
  + /opt/homebrew/bin/ifacemaker -f '/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/aws/aws-sdk-go-v2/service/cloudformation@v1.57.0/*.go' -s Client -i CloudFormation -p awsapi -y 'CloudFormation provides an interface to the AWS CloudFormation service.' -c 'Code generated by ifacemaker; DO NOT EDIT.' -m github.com/aws/aws-sdk-go-v2/service/cloudformation
  + '[' 2 -eq 2 ']'
  + SERVICE_NAME=cloudtrail
  + INTERFACE_NAME=CloudTrail
  + PACKAGE_NAME=github.com/aws/aws-sdk-go-v2/service/cloudtrail
  + go get github.com/aws/aws-sdk-go-v2/service/cloudtrail
  go: downloading github.com/aws/aws-sdk-go-v2/service/cloudtrail v1.47.4
  go: upgraded github.com/aws/aws-sdk-go-v2/service/cloudtrail v1.47.0 => v1.47.4
  ++ go list -m -f '{{.Dir}}' github.com/aws/aws-sdk-go-v2/service/cloudtrail
  + AWS_SDK_DIR=/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/aws/aws-sdk-go-v2/service/cloudtrail@v1.47.4
  + /opt/homebrew/bin/ifacemaker -f '/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/aws/aws-sdk-go-v2/service/cloudtrail@v1.47.4/*.go' -s Client -i CloudTrail -p awsapi -y 'CloudTrail provides an interface to the AWS CloudTrail service.' -c 'Code generated by ifacemaker; DO NOT EDIT.' -m github.com/aws/aws-sdk-go-v2/service/cloudtrail
  + '[' 2 -eq 2 ']'
  + SERVICE_NAME=elasticloadbalancing
  + INTERFACE_NAME=ELB
  + PACKAGE_NAME=github.com/aws/aws-sdk-go-v2/service/elasticloadbalancing
  + go get github.com/aws/aws-sdk-go-v2/service/elasticloadbalancing
  go: downloading github.com/aws/aws-sdk-go-v2/service/elasticloadbalancing v1.28.17
  go: upgraded github.com/aws/aws-sdk-go-v2/service/elasticloadbalancing v1.28.13 => v1.28.17
  ++ go list -m -f '{{.Dir}}' github.com/aws/aws-sdk-go-v2/service/elasticloadbalancing
  + AWS_SDK_DIR=/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/aws/aws-sdk-go-v2/service/elasticloadbalancing@v1.28.17
  + /opt/homebrew/bin/ifacemaker -f '/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/aws/aws-sdk-go-v2/service/elasticloadbalancing@v1.28.17/*.go' -s Client -i ELB -p awsapi -y 'ELB provides an interface to the AWS ELB service.' -c 'Code generated by ifacemaker; DO NOT EDIT.' -m github.com/aws/aws-sdk-go-v2/service/elasticloadbalancing
  + '[' 2 -eq 2 ']'
  + SERVICE_NAME=elasticloadbalancingv2
  + INTERFACE_NAME=ELBV2
  + PACKAGE_NAME=github.com/aws/aws-sdk-go-v2/service/elasticloadbalancingv2
  + go get github.com/aws/aws-sdk-go-v2/service/elasticloadbalancingv2
  go: downloading github.com/aws/aws-sdk-go-v2/service/elasticloadbalancingv2 v1.43.12
  go: upgraded github.com/aws/aws-sdk-go-v2/service/elasticloadbalancingv2 v1.43.8 => v1.43.12
  ++ go list -m -f '{{.Dir}}' github.com/aws/aws-sdk-go-v2/service/elasticloadbalancingv2
  + AWS_SDK_DIR=/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/aws/aws-sdk-go-v2/service/elasticloadbalancingv2@v1.43.12
  + /opt/homebrew/bin/ifacemaker -f '/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/aws/aws-sdk-go-v2/service/elasticloadbalancingv2@v1.43.12/*.go' -s Client -i ELBV2 -p awsapi -y 'ELBV2 provides an interface to the AWS ELBV2 service.' -c 'Code generated by ifacemaker; DO NOT EDIT.' -m github.com/aws/aws-sdk-go-v2/service/elasticloadbalancingv2
  + '[' 2 -eq 2 ']'
  + SERVICE_NAME=ssm
  + INTERFACE_NAME=SSM
  + PACKAGE_NAME=github.com/aws/aws-sdk-go-v2/service/ssm
  + go get github.com/aws/aws-sdk-go-v2/service/ssm
  go: downloading github.com/aws/aws-sdk-go-v2/service/ssm v1.56.12
  go: upgraded github.com/aws/aws-sdk-go-v2/service/ssm v1.56.8 => v1.56.12
  ++ go list -m -f '{{.Dir}}' github.com/aws/aws-sdk-go-v2/service/ssm
  + AWS_SDK_DIR=/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/aws/aws-sdk-go-v2/service/ssm@v1.56.12
  + /opt/homebrew/bin/ifacemaker -f '/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/aws/aws-sdk-go-v2/service/ssm@v1.56.12/*.go' -s Client -i SSM -p awsapi -y 'SSM provides an interface to the AWS SSM service.' -c 'Code generated by ifacemaker; DO NOT EDIT.' -m github.com/aws/aws-sdk-go-v2/service/ssm
  + '[' 2 -eq 2 ']'
  + SERVICE_NAME=iam
  + INTERFACE_NAME=IAM
  + PACKAGE_NAME=github.com/aws/aws-sdk-go-v2/service/iam
  + go get github.com/aws/aws-sdk-go-v2/service/iam
  go: downloading github.com/aws/aws-sdk-go-v2/service/iam v1.39.1
  go: upgraded github.com/aws/aws-sdk-go-v2/service/iam v1.38.8 => v1.39.1
  ++ go list -m -f '{{.Dir}}' github.com/aws/aws-sdk-go-v2/service/iam
  + AWS_SDK_DIR=/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/aws/aws-sdk-go-v2/service/iam@v1.39.1
  + /opt/homebrew/bin/ifacemaker -f '/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/aws/aws-sdk-go-v2/service/iam@v1.39.1/*.go' -s Client -i IAM -p awsapi -y 'IAM provides an interface to the AWS IAM service.' -c 'Code generated by ifacemaker; DO NOT EDIT.' -m github.com/aws/aws-sdk-go-v2/service/iam
  + '[' 2 -eq 2 ']'
  + SERVICE_NAME=eks
  + INTERFACE_NAME=EKS
  + PACKAGE_NAME=github.com/aws/aws-sdk-go-v2/service/eks
  + go get github.com/aws/aws-sdk-go-v2/service/eks
  go: downloading github.com/aws/aws-sdk-go-v2/service/eks v1.58.0
  go: upgraded github.com/aws/aws-sdk-go-v2/service/eks v1.57.0 => v1.58.0
  ++ go list -m -f '{{.Dir}}' github.com/aws/aws-sdk-go-v2/service/eks
  + AWS_SDK_DIR=/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/aws/aws-sdk-go-v2/service/eks@v1.58.0
  + /opt/homebrew/bin/ifacemaker -f '/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/aws/aws-sdk-go-v2/service/eks@v1.58.0/*.go' -s Client -i EKS -p awsapi -y 'EKS provides an interface to the AWS EKS service.' -c 'Code generated by ifacemaker; DO NOT EDIT.' -m github.com/aws/aws-sdk-go-v2/service/eks
  + '[' 2 -eq 2 ']'
  + SERVICE_NAME=outposts
  + INTERFACE_NAME=Outposts
  + PACKAGE_NAME=github.com/aws/aws-sdk-go-v2/service/outposts
  + go get github.com/aws/aws-sdk-go-v2/service/outposts
  go: downloading github.com/aws/aws-sdk-go-v2/service/outposts v1.48.7
  go: upgraded github.com/aws/aws-sdk-go-v2/service/outposts v1.48.4 => v1.48.7
  ++ go list -m -f '{{.Dir}}' github.com/aws/aws-sdk-go-v2/service/outposts
  + AWS_SDK_DIR=/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/aws/aws-sdk-go-v2/service/outposts@v1.48.7
  + /opt/homebrew/bin/ifacemaker -f '/Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/aws/aws-sdk-go-v2/service/outposts@v1.48.7/*.go' -s Client -i Outposts -p awsapi -y 'Outposts provides an interface to the AWS Outposts service.' -c 'Code generated by ifacemaker; DO NOT EDIT.' -m github.com/aws/aws-sdk-go-v2/service/outposts
  go generate ./pkg/eks
  go: downloading github.com/aws/amazon-ec2-instance-selector/v2 v2.4.2-0.20230601180523-74e721cb8c1e
  go: downloading github.com/aws/aws-sdk-go-v2/config v1.28.9
  go: downloading github.com/aws/aws-sdk-go-v2/credentials v1.17.50
  go: downloading github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.16.23
  go: downloading github.com/aws/aws-sdk-go-v2/service/sso v1.24.9
  go: downloading github.com/aws/aws-sdk-go-v2/service/ssooidc v1.28.8
  go: downloading github.com/aws/aws-sdk-go-v2/service/pricing v1.17.0
  go: downloading github.com/charmbracelet/bubbles v0.15.0
  go: downloading github.com/charmbracelet/bubbletea v0.24.1
  go: downloading github.com/charmbracelet/lipgloss v0.7.1
  go: downloading github.com/muesli/termenv v0.15.1
  go: downloading github.com/evertras/bubble-table v0.15.2
  go: downloading github.com/kubicorn/kubicorn v0.0.0-20180829191017-06f6bce92acc
  go: downloading github.com/oliveagle/jsonpath v0.0.0-20180606110733-2e52cf6e6852
  go: downloading github.com/sahilm/fuzzy v0.1.0
  go: downloading github.com/containerd/console v1.0.4-0.20230313162750-1ae8d489ac81
  go: downloading github.com/mattn/go-localereader v0.0.1
  go: downloading github.com/muesli/ansi v0.0.0-20211018074035-2e021307bc4b
  
  WARNING: Invoking counterfeiter multiple times from "go generate" is slow.
  Consider using counterfeiter:generate directives to speed things up.
  See https://github.com/maxbrunsfeld/counterfeiter#step-2b---add-counterfeitergenerate-directives for more information.
  Set the "COUNTERFEITER_NO_GENERATE_WARNING" environment variable to suppress this message.
  
  Writing `FakeKubeProvider` to `fakes/fake_kube_provider.go`... Done
  Writing `FakeAWSConfigurationLoader` to `fakes/fake_configuration_loader.go`... Done
  Writing `FakeFargateClient` to `fakes/fargate_client.go`... Done
  Writing `FakeInstanceSelector` to `fakes/fake_instance_selector.go`... Done
  Writing `FakeClusterVersionsManagerInterface` to `fakes/fake_cluster_versions_manager.go`... Done
  Writing `FakeAWSConfigurationLoader` to `fakes/fake_configuration_loader.go`... Done
  Writing `FakeFargateClient` to `fakes/fargate_client.go`... Done
  Writing `FakeInstanceSelector` to `fakes/fake_instance_selector.go`... Done
  Writing `FakeClusterVersionsManagerInterface` to `fakes/fake_cluster_versions_manager.go`... Done
  /opt/homebrew/bin/mockery
  12 Feb 25 00:56 UTC INF Starting mockery dry-run=false version=v2.52.1
  12 Feb 25 00:56 UTC INF Using config: /private/tmp/eksctl-20250211-84249-p8uvoi/.mockery.yaml dry-run=false version=v2.52.1
  2025/02/12 00:57:28 internal error: package "fmt" without types was imported from "github.com/aws/aws-sdk-go/aws/client"
  make: *** [generate-always] Error 1

Anything else we need to know?

Bumping

eksctl/go.mod

Line 77 in c0c9c1b

golang.org/x/tools v0.21.1-0.20240508182429-e35e4ccd0d2d

to 0.30.0 - https://github.com/golang/tools/releases/tag/v0.30.0
should help.

go get -u golang.org/x/tools@v0.30.0

Versions

$ eksctl info

Found in
@github-actions GitHub Actions
Copy link
Contributor

Hello stefanb 👋 Thank you for opening an issue in eksctl project. The team will review the issue and aim to respond within 1-5 business days. Meanwhile, please read about the Contribution and Code of Conduct guidelines here. You can find out more information about eksctl on our website

This was referenced Feb 12, 2025
Merged
Closed
@bryantbiggs bryantbiggs mentioned this issue Feb 12, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update building with golang 1.24 eksctl-io/eksctl
1 participant
@stefanb