Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling "cy.verifyDownload" with an empty string results in success #189

Open
BillyTom opened this issue Nov 11, 2024 · 0 comments
Open
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@BillyTom
Copy link

I have been using cy-verify-downloads version 0.2.4 for a while now, and I just noticed an unwanted behaviour.

I accidentally changed one of my test suites so that it would call verifyDownload with an empty string as a parameter. In that case the test would be marked as "pass", even though the file download was not actually tested. The log output in Cypress UI looked like this:

verifyDownload - Waiting for the file to be exist
task - isFileExist, /home/foobar/project/cypress/downloads
assert - The file has been downloaded successfully: expected true to be true

I think this is misleading behaviour. If "cy.verifyDownload" is called with an empty string, then the test case should fail.

@elaichenkov elaichenkov self-assigned this Nov 17, 2024
@elaichenkov elaichenkov added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants