Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistant color for focused buttons / download button is atm different #940

Closed
cgruber-uos opened this issue Jun 2, 2022 · 2 comments
Closed

Comments

@cgruber-uos
Copy link

cgruber-uos commented Jun 2, 2022

While testing the new introduced tab navigation (see #629) I noticed a different behavior of all next buttons vs. the download button on the final side:

All bottom right "next" buttons stay green while focusing with a wider also green border when focused:

2022-06-02 22_47_05-

But the download button is different: While tabbing and focusing it color changes to white and black text:

2022-06-02 22_47_49-Greenshot

This is not bad and perhaps the better solution than adding a green border to a green button. But it should be consistent for all similar UI elements. A download link is technically an other element than a button, but I think for a user it is more or less the same.

@lkiesow
Copy link
Contributor

lkiesow commented Jun 3, 2022

+1 for making this a green button as well.
Soonish, the new design is coming anyway, but no need to wait for that to fix this small inconsistency.

@narickmann
Copy link
Contributor

Fixed with commit 435cac1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants