Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Servereinstellungen nach Veranstaltungskategorien konfigurieren #218

Closed
sys-cr opened this issue Mar 25, 2021 · 13 comments
Closed

Servereinstellungen nach Veranstaltungskategorien konfigurieren #218

sys-cr opened this issue Mar 25, 2021 · 13 comments
Assignees
Milestone

Comments

@sys-cr
Copy link

sys-cr commented Mar 25, 2021

Folgende Änderungen wären wünschenswert:

  • Konfigurationsmöglichkeit im Backend für Server, um Studip-Veranstaltungskategorien (sem_classes) an einen Server zu binden.
    • Konfigurationsoption z.B. "Nur in folgenden Veranstaltungskategorien nutzbar" (Default: alle); Checkbox-Auswahl
    • Es soll z.B. für Studiengruppen nur möglich sein, einen von mehreren konfigurierten Servern (bzw. Loadbalancern) zu nutzen.
  • Deaktivierbare Servereinträge im Backend
@ferishili ferishili self-assigned this Mar 29, 2021
@tgloeggl tgloeggl added this to the >=2.60 milestone Mar 29, 2021
@ferishili
Copy link
Collaborator

ferishili commented Apr 1, 2021

@sys-cr, since you have the use-case, is it possible for you to perform an in-depth test for this feature?

@sys-cr
Copy link
Author

sys-cr commented Apr 6, 2021

@ferishili: Yes, should be possible at our Stud.IP-testing system at Leibniz University.

@ferishili
Copy link
Collaborator

Great, how do you prefer to get the beta version zip file? Or should I install it on that test server?

@sys-cr
Copy link
Author

sys-cr commented Apr 6, 2021

@ferishili and @crosscodr maybe you two can get in touch?

@crosscodr
Copy link
Contributor

Hi @ferishili, we deploy our plugins to the testserver with git directly. We maintain a fork of this repository. So the best solution would be a feature branch.

@ferishili
Copy link
Collaborator

Hi @crosscodr, I have created a new branch (https://github.com/virtUOS/studip-meeting/tree/beta_test), please try it out and let me know if it works fine!

@sys-cr
Copy link
Author

sys-cr commented Apr 6, 2021

@ferishili: thank you! we will let you know!

crosscodr added a commit to schuettloeffel-elsa/studip-meeting that referenced this issue Apr 6, 2021
@crosscodr
Copy link
Contributor

Hi @ferishili, the feature looks good to us :)
The only little improvement we would suggest, is the following. When creating a new meeting room, the user has to select one server, even if there is only one choice. In this case, the plugin could automatically choose the only available server. But thats a little one.
Thank you for the feature :)

@ferishili
Copy link
Collaborator

Hi @crosscodr, thank you for your feedback, I will get it done.

@ferishili
Copy link
Collaborator

ferishili commented Apr 12, 2021

Hi @ferishili, the feature looks good to us :)
The only little improvement we would suggest, is the following. When creating a new meeting room, the user has to select one server, even if there is only one choice. In this case, the plugin could automatically choose the only available server. But thats a little one.
Thank you for the feature :)

Hi, the feature of auto-selecting the server if there is only one available was already implemented and I could not reproduce the case you mentioned, please take a deeper look and let me know if you still have that problem!
Note: according to your commit above I could suggest to run the command (npm run zip), in order for the plugin to use all the resources it needs. thanks.

ferishili added a commit that referenced this issue Apr 12, 2021
course type + activation of servers, fixes #218
@crosscodr
Copy link
Contributor

Hi @ferishili,
the use case is the following: Create a new meeting-room. Then one can select a Driver, e.g. BBB. Now, the choice in "select server" field is not autoselected, even if there is only one server for this course-category. You have to test it at least with two servers; one selectable in the current course and another, which is not allowed in the course.
It's a little one, though.

Note: according to your commit above I could suggest to run the command (npm run zip), in order for the plugin to use all the resources it needs. thanks.
Yes, I put the contents of the zip in an extra branch to deploy it directly.

@ferishili ferishili reopened this Apr 12, 2021
ferishili added a commit to ferishili/studip-meeting that referenced this issue Apr 12, 2021
ferishili added a commit that referenced this issue Apr 12, 2021
auto select only availabe server, refs #218
@ferishili
Copy link
Collaborator

@crosscodr the complete feature with auto-select is merged into master, please have a look. Thank you for your productive request!

ferishili added a commit that referenced this issue Apr 12, 2021
@crosscodr
Copy link
Contributor

Thanks a lot! @ferishili

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants