Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement metrics #154

Closed
gregkalapos opened this issue Mar 21, 2019 · 8 comments
Closed

Implement metrics #154

gregkalapos opened this issue Mar 21, 2019 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@gregkalapos
Copy link
Contributor

Currently the .NET Agent does not send metrics. We don't take advantage of this feature at all.

Metrics are also shown on the UI and in case of the .NET Agent those charts are empty, so we should catch up on this feature.

Java Agent PR for ideas: elastic/apm-agent-java#360

@gregkalapos
Copy link
Contributor Author

Similarly to Java in step 1 (or step 0) we should make sure we fill the charts on Kibana - for this we need to send cpu and memory metrics.

Then we can also include agent specific metrics (e.g. gc metrics could be interesting). This can of course happen in 1 PR.

@francisminu
Copy link

francisminu commented Apr 12, 2019

Is this being developed at present? If so, is there a date by when this would be available?
Or is it up for grabs at present? @gregkalapos @alvarolobato

@alvarolobato
Copy link

No is not, but we plan to work on it very soon, probably in a few weeks.

@francisminu
Copy link

@alvarolobato
Will this include the ability to push custom metrics or just the system level and agent level metrics?

@gregkalapos
Copy link
Contributor Author

Hey @francisminu,

we don't have a 100% ready to implement plan on this one yet. Nevertheless, probably we will have system and some CLR metrics in the first iteration. I haven't looked at the details yet. Once we come up with a plan on what to implement in what stage I'll give a more detailed answer here.

@francisminu
Copy link

Thank you @gregkalapos
Looking forward to an update soon :)

@gregkalapos
Copy link
Contributor Author

A short update/summary on this issue.

Opened #248.

With that PR the agent will send some basic metrics to fill the Kibana charts under APM - my plan is to definitely make sure those lend with this PR. So basic memory and CPU metrics are covered.

The PR also contains new APIs as part of the Public Agent API to manually send custom metrics. This is public, so every user will have access to that API. The Go agent has something similar, other agents according to my current knowledge don't expose this API - nevertheless I think it's useful for .NET and adding it in the PR is very little additional work - so I think it'd make sense to also add that.

This is the plan for the Beta release. We'll have another iteration on this topic for adding more .NET specific metrics (like GC, etc..) Feedback on what would be useful is very appreciated.

@gregkalapos
Copy link
Contributor Author

#248 merged.

There won't be a public API now to send metrics manually, that'll come in another iteration. See the description of #248 for details about what metrics we send now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants