Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add special case value to disable ELASTIC_APM_SPAN_FRAMES_MIN_DURATION #465

Closed
Tracked by #654
axw opened this issue Mar 6, 2019 · 1 comment · Fixed by #1188
Closed
Tracked by #654

Add special case value to disable ELASTIC_APM_SPAN_FRAMES_MIN_DURATION #465

axw opened this issue Mar 6, 2019 · 1 comment · Fixed by #1188
Assignees
@stuartnelson3
Labels
agent-go breaking change
Milestone
8.1

Comments

@axw
Copy link
Member

axw commented Mar 6, 2019

Introduce a means of disabling capturing stack traces, by setting ELASTIC_APM_SPAN_FRAMES_MIN_DURATION to a special value of 0.

The other agents interpret a value of 0 to mean disable capturing stack traces, and -1 to always capture. We should do the same.
@axw
Copy link
Member Author

axw commented Jun 9, 2019

See elastic/apm#94

@axw axw mentioned this issue Dec 7, 2021
Closed
8 tasks
@simitt simitt added this to the 8.1 milestone Jan 5, 2022
@stuartnelson3 stuartnelson3 self-assigned this Jan 11, 2022
@axw axw mentioned this issue Jan 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stuartnelson3 stuartnelson3

Labels
agent-go breaking change
Projects
None yet
Milestone
8.1
Development

Successfully merging a pull request may close this issue.

handle special cases for span frames min duration stuartnelson3/apm-agent-go
4 participants
@axw @stuartnelson3 @simitt @alvarolobato