-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps-dev): bump undici from 6.2.1 to 6.3.0 #3827
Conversation
Bumps [undici](https://github.com/nodejs/undici) from 6.2.1 to 6.3.0. - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v6.2.1...v6.3.0) --- updated-dependencies: - dependency-name: undici dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
d8d21cd
to
e5fdbd3
Compare
https://nodejs.org/en/blog/release/v21.6.0 mentions the relevant change: nodejs/node#50827 I've opened #3833 to eventually support using this new Node.js feature to allow user's using |
…de v21.6.0 sets a default Error.prepareStackTrace
'error.exception.message', | ||
); | ||
// https://developer.mozilla.org/en-US/docs/Web/API/DOMException#aborterror | ||
t.equal(error.exception.code, '20', 'error.exception.code'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the lib instrumented changes the error codes and messages I guess it's expected and anyone having a query on ElasticSearch/Kibana should update it accordingly. But shouldn't error.exception.module
be defined here with the value undici
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC error.exception.module
comes from reading the err.stack
. Now that Undici is passing through the Error object set on the abort.reason
instead of creating its own, the err.stack
points to a location in Node.js core where it is created (this loc: https://github.com/nodejs/node/blob/e133e5115a829aa7a445cfd8754df3a3dd586b0a/lib/internal/abort_controller.js#L395). That means the top frame in err.stack
no longer points to a location in the undici
module.
* fix test assertions for AbortController changes in undici@6.3.0 * correct the 'Error.prepareStackTrace is not set' test assumptions, node v21.6.0 sets a default Error.prepareStackTrace Co-authored-by: Trent Mick <trent.mick@elastic.co>
Bumps undici from 6.2.1 to 6.3.0.
Release notes
Sourced from undici's releases.
... (truncated)
Commits
887d1cb
6.3.0cf74740
fix: add test helper for closing server as promise (#2604)5b0d401
fix: non-object error in abort throws bad error (#2597)62278d5
cacheStorage: fix bugs make wpts pass (#2596)77333e7
feat(#2191): Add support forNODE_DEBUG
(#2585)c89e3ff
feat: port tst test to node test runner (#2595)81e3d84
abort request with reason if one is provided (#2592)62efdad
Feat/migrate tests to node runner (#2593)133393e
fix: use isArrayBuffer instead of isAnyArrayBuffer (#2586)f7c8db8
feat: port remaining fetch tests to node test runner (#2587)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major version
will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor version
will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>
will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>
will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>
will remove the ignore condition of the specified dependency and ignore conditions