Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of data_stream fields causes allocations when data streams are disabled #4460

Closed
axw opened this issue Nov 25, 2020 · 0 comments · Fixed by #4461
Closed

Addition of data_stream fields causes allocations when data streams are disabled #4460

axw opened this issue Nov 25, 2020 · 0 comments · Fixed by #4461
Assignees
Labels

Comments

@axw
Copy link
Member

axw commented Nov 25, 2020

Since #4409 was merged, there has been an increase in the allocations in hey-apm benchmarks:

image

Making some changes locally, this appears to be entirely due to the additional data_stream.* fields. When data streams are disabled, we add these fields and then later remove them with a processor (allowing centralisation of that logic).

The impact is more significant than I expected, and we should consider changing how this works: only add the fields when data streams are enabled. This could be done by adding a new field to transform.Config.

@axw axw added the bug label Nov 25, 2020
@axw axw added this to the 7.11 milestone Nov 25, 2020
@axw axw self-assigned this Nov 25, 2020
@axw axw removed their assignment Nov 25, 2020
@axw axw removed this from the 7.11 milestone Nov 25, 2020
@axw axw self-assigned this Nov 25, 2020
@axw axw closed this as completed in #4461 Nov 25, 2020
@axw axw removed the [zube]: Done label Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant