Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filebeat system visualisation do not use ECS #11859

Closed
fkelbert opened this issue Apr 17, 2019 · 7 comments · Fixed by #11936
Closed

Filebeat system visualisation do not use ECS #11859

fkelbert opened this issue Apr 17, 2019 · 7 comments · Fixed by #11936
Assignees
Labels
bug Filebeat Filebeat module Team:Integrations Label for the Integrations team

Comments

@fkelbert
Copy link

With 7.0, some Filebeat system visualisation do not work, as they do not use proper ECS fields.

Specifically the visualisation:

  • SSH users of failed login attempts [Filebeat System] ECS
  • Successful SSH logins
  • SSH login attempts

These visualisations should filter on field system.auth.ssh.event rather than event.action.

@ruflin
Copy link
Member

ruflin commented Apr 24, 2019

Hi @fkelbert Thanks for reporting. This seems to be indeed a field that was renamed but should not have been renamed in the dashboards. @webmat Does this ring a bell on your end?

@webmat
Copy link
Contributor

webmat commented Apr 24, 2019

I agree the searches and visualizations should still use the custom fields. Here's what happened.

My initial PR #9138 to migrate the system module did migrate this field to the ECS field event.action.

But later, we decided to use a few of the event fields for guided categorization, and event.action is one of the fields that used for this. PR #11334 by @tsg made the corresponding change to the system module's pipeline, but the entry for system.auth.ssh.event => event.action was not removed from ecs-migration.yml.

We should indeed address this for the next patch release, should be straightforward to fix.

@webmat
Copy link
Contributor

webmat commented Apr 25, 2019

Hmmm, it seems like the ecs-migration.yml file doesn't contain this incorrect mapping anymore.

I'll fix the dashboards directly.

@webmat
Copy link
Contributor

webmat commented Apr 25, 2019

Fix for master is up: #11936. I'll backport to 7.0 as soon as it's merged.

The incorrect entry is no longer in ecs-migration.yml, as already mentioned. The list of breaking changes doesn't seem to contain this incorrect migration either. So I only really had to fix the dashboard itself.

@ruflin
Copy link
Member

ruflin commented Apr 26, 2019

Thanks for the fix Mat.

@ruflin
Copy link
Member

ruflin commented Apr 30, 2019

@webmat Not sure why this was reopend? Both PR's are merged.

@webmat
Copy link
Contributor

webmat commented Apr 30, 2019

Hmmm, it got auto-closed by my first merge to master, which was incorrect.

I reopened temporarily, but I assumed the merge of the backport would close it again. Looks like it didn't :-)

Closing now

@webmat webmat closed this as completed Apr 30, 2019
@zube zube bot removed the [zube]: In Review label Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Filebeat Filebeat module Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants