-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metricbeat]Create kube-state-metrics metricset which includes all info #12938
Comments
+1 to doing this. It would be helpful to include examples to drop the metrics the user may not want. It would be a nice workaround to support several reporting periods too. Did you think about how to make this backwards compatible? sounds like you could release the new metriset and deprecate the rest at some point (to be removed in 8.0) |
I thought about creating a new metricset Regarding drop events and the enricher I think they can also be somehow improved.
(I wrote a multi paragraph response to this, but the scope was growing too much, will keep them and manage to add them as issues as we evolve) |
About enrichment, I hope we get opinionated about it. Making things optional means that users can disable them. If we use these fields in the UI or dashboards, disabling them would break the experience. We are trying to go in the other direction to avoid these issues, for instance: #13068 |
About enrichment, as this moves forward it may be ok to make this module work with it instead of hardcoding things in: #14044 |
Just a concern. Will this be scalable in the long run while adding more and more 🤔 |
Maybe we let users specify the namespaces they are interested in similar to the generic AWS CloudWatch metrics module? |
Because of how That said, we should pay attention to the output we get and it's size, it could be the case that we don't find some of the metrics interesting enough and can avoid reporting them. |
Closing this as we abandoned this idea in favor of the current approach |
Describe the enhancement:
Currently
kube-state-metrics
info is rerieved using a range of metricsets.Each metricset manages an object, targeting:
container
deployment
node
pod
replicaset
statefulset
This is a proposal to create a
kube-state-metrics
metricset that includes groups then all, including missing requested objects.Benefits:
Cons:
related: #7058
The text was updated successfully, but these errors were encountered: