Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Filebeat] Cleanup channelContext and s3Context in s3 input #13129

Closed
kaiyan-sheng opened this issue Jul 31, 2019 · 4 comments
Closed

[Filebeat] Cleanup channelContext and s3Context in s3 input #13129

kaiyan-sheng opened this issue Jul 31, 2019 · 4 comments
Assignees
@urso
Labels
enhancement Filebeat Filebeat needs_team Indicates that the issue/PR needs a Team:* label

Comments

@kaiyan-sheng
Copy link
Contributor

kaiyan-sheng commented Jul 31, 2019 •
edited
Loading

After common patterns are collected in github.com/elastic/go-concert, both channelContext and s3Context can be removed and replaced by the common pattern. This issue is to track the work mentioned in #12640 (comment) by @urso .
@botelastic
Copy link

botelastic bot commented Jul 8, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@botelastic botelastic bot added Stalled needs_team Indicates that the issue/PR needs a Team:* label labels Jul 8, 2020
@botelastic
Copy link

botelastic bot commented Jul 8, 2020

This issue doesn't have a Team:<team> label.

@urso urso self-assigned this Jul 8, 2020
@botelastic botelastic bot removed the Stalled label Jul 8, 2020
@urso
Copy link

urso commented Jul 9, 2020

In progress PR: #19756

@jsoriano
Copy link
Member

I guess this was solved in #20005, so I am closing this. @kaiyan-sheng, please reopen if you think that this is still an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@urso urso

Labels
enhancement Filebeat Filebeat needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jsoriano @urso @kaiyan-sheng