Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] ActiveMQ module #14744

Closed
10 tasks done
mtojek opened this issue Nov 25, 2019 · 5 comments
Closed
10 tasks done

[Filebeat] ActiveMQ module #14744

mtojek opened this issue Nov 25, 2019 · 5 comments
Assignees
Labels
enhancement Filebeat Filebeat module Team:Integrations Label for the Integrations team

Comments

@mtojek
Copy link
Contributor

mtojek commented Nov 25, 2019

Introduction

As the Metricbeat for ActiveMQ has been delivered in #14510 , a corresponding filebeat should be also implemented.

Logging is enabled using Log4j appenders. Default logging configuration:

# Console appender
log4j.appender.console=org.apache.log4j.ConsoleAppender
log4j.appender.console.layout=org.apache.log4j.PatternLayout
log4j.appender.console.layout.ConversionPattern=%5p | %m%n
log4j.appender.console.threshold=INFO

# File appender
log4j.appender.logfile=org.apache.log4j.RollingFileAppender
log4j.appender.logfile.file=${activemq.data}/activemq.log
log4j.appender.logfile.maxFileSize=1024KB
log4j.appender.logfile.maxBackupIndex=5
log4j.appender.logfile.append=true
log4j.appender.logfile.layout=org.apache.log4j.PatternLayout
log4j.appender.logfile.layout.ConversionPattern=%d | %-5p | %m | %c | %t%n

(source: https://github.com/apache/activemq/blob/7d14ddb0d15c9221f35318661c98f4993b94e3bd/activemq-all/src/main/resources/log4j.properties)

Modules

For a fileset to go GA, the following criterias should be met:

  • Supported versions are documented
  • Supported operating systems are documented (if applicable)
  • Integration tests exist
    *[ ] System tests exist
  • Automated checks that all fields are documented
  • Documentation
  • Fields follow ECS and naming conventions
  • Dashboards exists (if applicable)
  • Kibana Home Tutorial (if applicable)
    • Open PR against Kibana repo with tutorial. Examples can be found here.

Filebeat module

  • Test log files exist for the grok patterns
  • Generated output for at least 1 log file exists
@mtojek mtojek self-assigned this Nov 25, 2019
@mtojek
Copy link
Contributor Author

mtojek commented Nov 26, 2019

To be also addressed in the PR:

Apart from the general application logging, ActiveMQ provides also audit logs. Briefly described here: https://activemq.apache.org/audit-logging

Audit logger appender:

log4j.appender.audit=org.apache.log4j.RollingFileAppender
log4j.appender.audit.file=${activemq.data}/audit.log
log4j.appender.audit.maxFileSize=1024KB
log4j.appender.audit.maxBackupIndex=5
log4j.appender.audit.append=true
log4j.appender.audit.layout=org.apache.log4j.PatternLayout
log4j.appender.audit.layout.ConversionPattern=%-5p | %m | %t%n

@exekias
Copy link
Contributor

exekias commented Nov 27, 2019

I updated the description to put back the Modules section, it affects both to Metricbeat and Filebeat modules

@mtojek
Copy link
Contributor Author

mtojek commented Dec 2, 2019

Status table has been updated. I'm proceeding with dashboards.

@mtojek
Copy link
Contributor Author

mtojek commented Dec 3, 2019

All action items have been cleared. I will proceed with backports.

@mtojek
Copy link
Contributor Author

mtojek commented Dec 3, 2019

All backports have been merged. Resolving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Filebeat Filebeat module Team:Integrations Label for the Integrations team
Projects
None yet
Development

No branches or pull requests

3 participants