Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Make APM tracer configurable #18360

Closed
jalvz opened this issue May 7, 2020 · 1 comment · Fixed by #18861
Closed

[APM] Make APM tracer configurable #18360

jalvz opened this issue May 7, 2020 · 1 comment · Fixed by #18861
Labels

Comments

@jalvz
Copy link
Contributor

jalvz commented May 7, 2020

Describe the enhancement:

#17938 bring instrumentation to libbeat. However, the only way to configure the tracer is with environment variables. For a better experience, it would be ideal to configure it in the same way as other settings (via yaml, or -E args), and expose it (via Getter in the pipeline or similar) so that all beats can use it. This is particularly beneficial for APM Server and community Beats.

I therefore suggest a top level instrumentation namespace in the yaml config, initially with the following settings underneath:

  • enabled: disabled by default
  • environment: optional, typically prod, staging, etc - this info is reported by the agent and showed in Kibana
  • hosts: apm server urls
  • secret_token: for apm-server secure communication, optional
  • api_key: for apm-server secure communication, optional
  • profiling: experimental feature to report CPU and heap profiles, disabled by default

Describe a specific use case for the enhancement or feature:

The configuration proposed above is implemented already in APM Server. But every beat that wants a similar experience would need to create its own configuration and initialize the tracer accordingly.
It makes more sense to do it centrally and then all the beats would get it for free.

@jalvz jalvz added enhancement feedback needed Team:apm APM Server team issues/PRs labels May 7, 2020
@jalvz
Copy link
Contributor Author

jalvz commented May 7, 2020

@elastic/beats does this makes sense to you?

cc @elastic/apm-server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant