Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary restarts of metricsets while using Pod/Service autodiscover #20311

Closed
ChrsMark opened this issue Jul 29, 2020 · 3 comments
Closed
Assignees
Labels
good first issue Indicates a good issue for first-time contributors Team:Platforms Label for the Integrations - Platforms team

Comments

@ChrsMark
Copy link
Member

Describe the enhancement:
Improve update checks for pod and service resources to avoid having unnecessary restarts of metricsets.
Similar to #19974.

@ChrsMark ChrsMark added good first issue Indicates a good issue for first-time contributors Team:Platforms Label for the Integrations - Platforms team labels Jul 29, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@ChrsMark
Copy link
Member Author

I did some first investigation for this and it looks like Pods (and most probably services) are properly handled on Updates:

// If Pod is in a phase where all containers in the have terminated emit a stop event

I also added debug messages to observe the updates and I didn't catch any update that we don't handle properly and can cause unnecessary restarts. I think that we are ok with the current state.

@jsoriano do you have any ideas around this? Otherwise we can close it.

@jsoriano
Copy link
Member

I did some first investigation for this and it looks like Pods (and most probably services) are properly handled on Updates:

// If Pod is in a phase where all containers in the have terminated emit a stop event

I also added debug messages to observe the updates and I didn't catch any update that we don't handle properly and can cause unnecessary restarts. I think that we are ok with the current state.

@jsoriano do you have any ideas around this? Otherwise we can close it.

Yep, I am ok with closing this, thanks for the investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Indicates a good issue for first-time contributors Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

No branches or pull requests

3 participants