Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple IPs in envoy module #22715

Closed
hochraldo opened this issue Nov 23, 2020 · 3 comments
Closed

Support multiple IPs in envoy module #22715

hochraldo opened this issue Nov 23, 2020 · 3 comments
Labels
Stalled Team:Platforms Label for the Integrations - Platforms team

Comments

@hochraldo
Copy link

Currently the envoy module only supports one IP for the X-Forwarded-For header into the envoy access logs.
However, according to https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Forwarded-For this header can contain multiple IP addresses. That's why an envoy access log can have the following entry (with the default access log format set: https://www.envoyproxy.io/docs/envoy/v1.10.0/configuration/access_log#default-format-string)

[2020-11-23T15:32:25.590Z] "GET /ping/ HTTP/1.0" 200 - 0 1 0 - "XXX.XXX.XXX.XXX,YYY.YYY.YYY.YYY" "-" "5ecb371a-b443-458f-969a-34c69b6ba4f2" "somehost.somedomain.com" "-"

This issue looks to similar to this one mentioned here: #4322

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 23, 2020
@andresrc andresrc added the Team:Platforms Label for the Integrations - Platforms team label Nov 23, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 23, 2020
@ChrsMark
Copy link
Member

Possibly helpful PR: #21215

@botelastic
Copy link

botelastic bot commented Jan 27, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@botelastic botelastic bot added the Stalled label Jan 27, 2022
@botelastic botelastic bot closed this as completed Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stalled Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

No branches or pull requests

4 participants