Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Meta] Standardize DataStream handling / config parsing #24361

Closed
4 tasks
andrewvc opened this issue Mar 4, 2021 · 1 comment
Closed
4 tasks

[Meta] Standardize DataStream handling / config parsing #24361

andrewvc opened this issue Mar 4, 2021 · 1 comment

Comments

@andrewvc
Copy link
Contributor

andrewvc commented Mar 4, 2021

In #24223 I introduced a new add_data_stream_index processor that provides a very clean way for handling data stream configs and data stream index formatting. Today that's only used for Heartbeat, but as @urso pointed out a similar strategy would make sense for the other beats as well, probably leveraging some of the same utilities.

The basic idea is to centralize two bits of logic:

  1. DataStream configs (which exist at both the input and the stream level)
  2. The index name generation

The processor above handles the index name generation (and allows individual events to override the dataset via metadata). The first bit of logic, merging the dual data_stream declarations, is handled in a bespoke way for heartbeat, but could probably be centralized with a helper function after applying it to one other beat to find the commonalities.

This issue exists to track this unification effort.

The below list tracks implementation across the following beats:

  • Filebeat
  • Packetbeat
  • Metricbeat
  • APM Server
@botelastic
Copy link

botelastic bot commented Oct 27, 2022

Hi!
We just realized that we haven't looked into this issue in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1.
Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Oct 27, 2022
@botelastic botelastic bot closed this as completed Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants