service.address unexpectedly removed from some metricsets

[jsoriano]

Some metricsets don't have the service.address field when they were expected to have it.

It seems to happen since #21022. It may be the case that metricsets that don't have a sanitized URI in their host data don't have a service.address now. We want to keep both features, sanitized URIs to avoid credential leaks, and service.address field to identify services in different hosts.

Seen with the vsphere module, but it may affect others.

For confirmed bugs, please report:

• Version: 7.10 to master
• Operating System: All
• Steps to Reproduce: Enable one of the affected modules, run it and check that service.address is not present.

Metricsets that might be affected for this issue (because they don't register a host parser):

• metricbeat/module/aerospike/namespace
• metricbeat/module/docker/network_summary
• metricbeat/module/graphite/server
• metricbeat/module/kafka/consumergroup
• metricbeat/module/kvm/dommemstat
• metricbeat/module/kvm/status
• metricbeat/module/munin/node
• metricbeat/module/vsphere Use common host parser in vsphere module #26904
• x-pack/metricbeat/module/iis/application_pool
• x-pack/metricbeat/module/iis/webserver
• x-pack/metricbeat/module/iis/website
• x-pack/metricbeat/module/statsd/server
• Cloud and system modules may be also affected, but do they need this field?

Other related issues:

• There are some modules still using mb.Registry.AddMetricSet, initialization of host parser is different there (Use MustAddMetricSet in all metricsets #26907).
• Generation of data.json files is not doing the same as a running Metricbeat, different values are generated for service.address (e.g. aerospike doesn't generate service.address in Metricbeat, but it does when generating the data.json).

[elasticmachine]

Pinging @elastic/integrations (Team:Integrations)

[jsoriano]

I am afraid that all metricsets that don't have a host parser (or explicitly set the sanitized URI in some other way) are affected by this, we should check all these metricsets. But this hasn't been reported frequently, so maybe this is not such an important issue.

[jsoriano]

Added the list of metricsets without host parser, they are not so many.

[ishleenk17]

@jsoriano : Is service.address not seen in some specific scenario ?
For vsphere integration, I am seeing the service.address in the vents generated.

[jsoriano]

@ishleenk17 this issue was fixed for vsphere in #26904, I will update the description to avoid confusion.

I don't know what is the current status for other metricsets.

[botelastic]

Hi!
We just realized that we haven't looked into this issue in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1.
Thank you for your contribution!