Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate filebeat and metricbeat to the V2 agent specification file format #31900

Open
Tracked by #32
cmacknz opened this issue Jun 9, 2022 · 6 comments
Open
Tracked by #32
Labels
Agent Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team v8.4.0

Comments

@cmacknz
Copy link
Member

cmacknz commented Jun 9, 2022

As part of the V2 architecture changes the agent specification file format is being redesigned to remove automatic configuration transformations like inject_stream_processor.

Both filebeat and metricbeat currently rely on a variety of configuration file transformations when run under agent which must be removed:

The scope of this issue is to move the logic for each of these configuration transformations into the beat itself when it detects it is being run under agent (for example, seeing the -management.enabled flag on the command line).

Relates To:

This task is considered complete when a test exists proving that filebeat and metricbeat behave correctly when started using their V2 specification file. This includes but is not limited to testing that:

  • There were no unexpected changes to the format of published documents.
  • Each available input defined in the specification file can be started.
  • Policy changes adding processors, inputs, or new output configurations take effect as expected.
@cmacknz cmacknz self-assigned this Jun 9, 2022
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 9, 2022
@cmacknz cmacknz added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Jun 9, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 9, 2022
@cmacknz
Copy link
Member Author

cmacknz commented Jun 15, 2022

Assigning to @rdner as I think the work here will probably be a natural continuation of #33135 for the shipper.

@cmacknz
Copy link
Member Author

cmacknz commented Jun 21, 2022

There is a chance this overlaps with the work needed for #31901, ideally they can be done independently but we'll need to sync up first.

@cmacknz cmacknz assigned fearful-symmetry and unassigned rdner Jun 30, 2022
@cmacknz
Copy link
Member Author

cmacknz commented Jun 30, 2022

I think it will make sense for @fearful-symmetry to take this over as it is linked strongly to #31901

@fearful-symmetry
Copy link
Contributor

Yah, still trying to figure out how to grapple with this.

@cmacknz I assume the goal here is to treat the V2 config system as the "default" for how things work, meaning we make the beats backwards-compatible, and future V2 imputs need no config transformation to start with.

I'm undecided on if we can/should "port" that transformation code/spec config into the beats, and have them basically apply the transformations once we get the config from agent. The alternative would be something more piecemeal with custom code for each beat.

@cmacknz
Copy link
Member Author

cmacknz commented Jun 30, 2022

@cmacknz I assume the goal here is to treat the V2 config system as the "default" for how things work, meaning we make the beats backwards-compatible, and future V2 imputs need no config transformation to start with.

👍 Yes, we want to obsolete the V1 spec files and only use the V2 specs that do not allow transformations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Agent Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team v8.4.0
Projects
None yet
Development

No branches or pull requests

5 participants