Bug 384 redis fail #402
Merged
Bug 384 redis fail #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 25, 2015 20:28
Do not set message.Bulks to nil after setting message to nil
Parse strings not until CRLF, but use message length field to get full message. Fixes poblems with messages bodies containing CRLF.
split parser and unexport/rename some types
Add support for pipelining by storing all requests and responses in lists to be correlated by order. Responses without requests are dropped (original behavior). If TCP connection times out, the response will be lost too.
Added unit tests for cases redis parser has had problems with + rewrite parser to fix those issues. - length prefixed strings containing '\r\n' have not been fully read => message dropped => connection/correlation in invalid state - nested arrays parsing 'unreliable' (code did assume no nesting) - restart/continue parsing is message is split in multiple TCP segments. Internal parser state was invalid such that TCP stream was sometimes not fully processed at all and transaction have been dropped or message required to be dropped ending in potentially wrong correlations.
|
LGTM. Looks like you found more issues than just the one you were initially after. |
|
LGTM. Also the renaming / cleanup part is nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #384
Fix a number of issues found in redis protocol plugin: