Remove deprecated Init(), pass instance.Settings around. #10721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure settings from rootCmd are respected also when calling `export` and `setup`. fixes elastic#10720
houndci-bot
reviewed
Feb 13, 2019
houndci-bot
reviewed
Feb 13, 2019
simitt
force-pushed
the
cmds-use-settings
branch
from
1d93708
to
15fc3a1
Compare
simitt
force-pushed
the
cmds-use-settings
branch
from
15fc3a1
to
88dcec0
Compare
simitt
force-pushed
the
cmds-use-settings
branch
from
d2837f8
to
d5c053f
Compare
|
Failing tests are unrelated afaik. |
|
EDIT: I also found |
kvch
reviewed
Feb 14, 2019
libbeat/cmd/instance/beat.go
Outdated
| @@ -681,6 +681,7 @@ func (b *Beat) loadDashboards(ctx context.Context, force bool) error { | |||
| } | |||
|
|
|||
| if b.Config.Dashboards.Enabled() { | |||
|
|
|||
|
While the |
|
Thank you! |
kvch
approved these changes
Feb 14, 2019
|
jenkins, retest this please |
simitt
added
the
needs_backport
This was referenced Feb 14, 2019
simitt
added a commit
to simitt/beats
that referenced
this pull request
Feb 15, 2019
* Remove deprecated Init(), pass instance.Settings around. Ensure settings from rootCmd are respected also when calling `export` and `setup`. fixes elastic#10720
simitt
added a commit
that referenced
this pull request
Feb 15, 2019
DStape
pushed a commit
to DStape/beats
that referenced
this pull request
Aug 20, 2019
* Remove deprecated Init(), pass instance.Settings around. Ensure settings from rootCmd are respected also when calling `export` and `setup`. fixes elastic#10720
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently following deprecated methods do not take
instance.Settingsas argumentGenRootCmd,GenRootCmdWithRunFlagsandGenRootCmdWithIndexPrefixWithRunFlags. Internally some commands also don't take theinstance.Settingsas params (genSetupCmd,genKeystoreCmd, ..). Since the introduction ofsettings.ILMandsettings.IndexManagement(https://github.com/elastic/beats/blob/master/libbeat/cmd/instance/settings.go#L41) this can lead to errors, as the defined Index and ILM Supporters might not be respected.This PR intends to
instance.Settingas parameter so all configurations can be respected.fixes #10720