Add AWS s3_daily_storage metricset #10940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Feb 25, 2019
x-pack/metricbeat/module/aws/s3_daily_storage/s3_daily_storage_integration_test.go
Show resolved
Hide resolved
kaiyan-sheng
added
Metricbeat
sayden
reviewed
Feb 26, 2019
sayden
reviewed
Feb 26, 2019
sayden
reviewed
Feb 26, 2019
sayden
reviewed
Feb 26, 2019
sayden
reviewed
Feb 26, 2019
sayden
reviewed
Feb 26, 2019
sayden
reviewed
Feb 26, 2019
x-pack/metricbeat/module/aws/s3_daily_storage/s3_daily_storage.go
Outdated
Show resolved
Hide resolved
sayden
reviewed
Feb 26, 2019
x-pack/metricbeat/module/aws/s3_daily_storage/s3_daily_storage.go
Outdated
Show resolved
Hide resolved
sayden
reviewed
Feb 26, 2019
|
jenkins, test this please |
sayden
approved these changes
Feb 27, 2019
kaiyan-sheng
referenced
this pull request
Mar 1, 2019
* Add s3_request metricset for AWS module * Add changelog * Change metric names and add a check for timestamp * Add ms unit to latency metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add s3_daily_storage metricset to AWS module.
Metrics:
bucket.name
bucket.size.bytes
number_of_objects
These metrics came from Amazon S3 CloudWatch Daily Storage Metrics for Buckets. These storage metrics for Amazon S3 are reported once per day, which indicates the collection period for s3_daily_storage metricset should be 86400s or multiple of 86400s.
#10055