decode_json_field: do not process arrays when flag not set #11318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvch
reviewed
Mar 20, 2019
| @@ -199,6 +199,53 @@ func TestTargetRootOption(t *testing.T) { | |||
| assert.Equal(t, expected.String(), actual.String()) | |||
| } | |||
|
|
|||
| func TestArrayWithArraysDisabled(t *testing.T) { | |||
There was a problem hiding this comment.
Do you mind adding test cases for decoding array when process_array is set to true? Also, it would be nice to see tests for max_depth. The coverage of decode_json_fields is pretty thin. :(
There was a problem hiding this comment.
kvch
reviewed
Mar 20, 2019
andrewkroh
approved these changes
Mar 20, 2019
There was a problem hiding this comment.
LGTM. Just the changelog needs a newline like @kvch suggests.
kvch
approved these changes
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using arrays with decode_json_processor array is decoded even though
ProcessArrayconfiguration is set tofalseWith input and
ProcessArrayset tofalse:Current behavior
Expected behavior:
Fixes #11314