[functionbeat] Fix function name reference for Kinesis streams in CF templates #11646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
jenkins test this |
kvch
approved these changes
Apr 23, 2019
ph
approved these changes
Apr 23, 2019
|
@gemabarni could you add a changelog entry in https://github.com/elastic/beats/blob/master/CHANGELOG.next.asciidoc |
gemabarni
force-pushed
the
functionbeat-name-reference-fix
branch
from
c50107a
to
ee6eab4
Compare
gemabarni
force-pushed
the
functionbeat-name-reference-fix
branch
from
ee6eab4
to
261a213
Compare
|
@ph done |
|
jenkins test this |
ph
added
Functionbeat
review
needs_backport
|
Thanks @gemabarni |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the issue when function names containing non-alphanumerical characters cause the CloudFormation template to be invalid when using Kinesis as a trigger.
A normalized name of the function is added to the
Resourcessection of the template as a key, so the value ofFunctionNamereferencing the function should be normalized as well.