[Heartbeat] Fix NPE on monitor configuration errors #11910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewvc
added
bug
in progress
|
Pinging @elastic/uptime |
andrewvc
force-pushed
the
fix-npe-stopping-new-monitor
branch
from
8807805
to
41c11b9
Compare
These errors cause the `newMonitor` constructor to return a nil object plus error. Without a nil check we get an NPE. Fixes elastic#11747
andrewvc
force-pushed
the
fix-npe-stopping-new-monitor
branch
from
41c11b9
to
bc506ad
Compare
andrewvc
added
review
needs_backport
ruflin
approved these changes
Apr 24, 2019
andrewvc
added a commit
to andrewvc/beats
that referenced
this pull request
Apr 24, 2019
These errors cause the `newMonitor` constructor to return a nil object plus error. Without a nil check we get an NPE. Fixes elastic#11747 (cherry picked from commit ac37fa3)
andrewvc
added
v7.2.0
and removed
needs_backport
andrewvc
added a commit
to andrewvc/beats
that referenced
this pull request
Apr 24, 2019
These errors cause the `newMonitor` constructor to return a nil object plus error. Without a nil check we get an NPE. Fixes elastic#11747 (cherry picked from commit ac37fa3)
andrewvc
added a commit
that referenced
this pull request
Apr 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These errors cause the
newMonitorconstructor to return a nil object plus error. Without a nil check we get an NPE.Fixes #11747