[Auditbeat][Metricbeat] Fix direction of incoming IPv6 sockets #12248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwurm
added
bug
review
Metricbeat
|
jenkins, test this |
cwurm
added
v7.2.0
and removed
needs_backport
cwurm
pushed a commit
to cwurm/beats
that referenced
this pull request
May 23, 2019
…ic#12248) To determine the direction of a socket, we save the list of listening sockets and match non-listening sockets to them. If we find a match, the non-listening socket is `Incoming`, otherwise `Outgoing`. A problem occurs when matching an IPv6 socket listening on all interfaces (`::`) with an IPv6 socket that has an IPv4-mapped IPv6 address (e.g. `::ffff:127.0.0.1`). Golang's `To4()` will determine it is an IPv4 address and miss the listening IPv6 socket. With this PR, we specify the IP family explicitly instead of trying to determine it from the IP address. Fixes elastic#3306. (cherry picked from commit 5dcc369)
cwurm
pushed a commit
to cwurm/beats
that referenced
this pull request
May 23, 2019
…ic#12248) To determine the direction of a socket, we save the list of listening sockets and match non-listening sockets to them. If we find a match, the non-listening socket is `Incoming`, otherwise `Outgoing`. A problem occurs when matching an IPv6 socket listening on all interfaces (`::`) with an IPv6 socket that has an IPv4-mapped IPv6 address (e.g. `::ffff:127.0.0.1`). Golang's `To4()` will determine it is an IPv4 address and miss the listening IPv6 socket. With this PR, we specify the IP family explicitly instead of trying to determine it from the IP address. Fixes elastic#3306. (cherry picked from commit 5dcc369)
cwurm
pushed a commit
that referenced
this pull request
May 23, 2019
… (#12250) To determine the direction of a socket, we save the list of listening sockets and match non-listening sockets to them. If we find a match, the non-listening socket is `Incoming`, otherwise `Outgoing`. A problem occurs when matching an IPv6 socket listening on all interfaces (`::`) with an IPv6 socket that has an IPv4-mapped IPv6 address (e.g. `::ffff:127.0.0.1`). Golang's `To4()` will determine it is an IPv4 address and miss the listening IPv6 socket. With this PR, we specify the IP family explicitly instead of trying to determine it from the IP address. Fixes #3306. (cherry picked from commit 5dcc369)
cwurm
pushed a commit
that referenced
this pull request
May 23, 2019
… (#12251) To determine the direction of a socket, we save the list of listening sockets and match non-listening sockets to them. If we find a match, the non-listening socket is `Incoming`, otherwise `Outgoing`. A problem occurs when matching an IPv6 socket listening on all interfaces (`::`) with an IPv6 socket that has an IPv4-mapped IPv6 address (e.g. `::ffff:127.0.0.1`). Golang's `To4()` will determine it is an IPv4 address and miss the listening IPv6 socket. With this PR, we specify the IP family explicitly instead of trying to determine it from the IP address. Fixes #3306. (cherry picked from commit 5dcc369)
cwurm
pushed a commit
to cwurm/beats
that referenced
this pull request
May 23, 2019
…ic#12248) To determine the direction of a socket, we save the list of listening sockets and match non-listening sockets to them. If we find a match, the non-listening socket is `Incoming`, otherwise `Outgoing`. A problem occurs when matching an IPv6 socket listening on all interfaces (`::`) with an IPv6 socket that has an IPv4-mapped IPv6 address (e.g. `::ffff:127.0.0.1`). Golang's `To4()` will determine it is an IPv4 address and miss the listening IPv6 socket. With this PR, we specify the IP family explicitly instead of trying to determine it from the IP address. Fixes elastic#3306. (cherry picked from commit 5dcc369)
cwurm
pushed a commit
that referenced
this pull request
May 23, 2019
…ncoming IPv6 sockets (#12249) To determine the direction of a socket, we save the list of listening sockets and match non-listening sockets to them. If we find a match, the non-listening socket is `Incoming`, otherwise `Outgoing`. A problem occurs when matching an IPv6 socket listening on all interfaces (`::`) with an IPv6 socket that has an IPv4-mapped IPv6 address (e.g. `::ffff:127.0.0.1`). Golang's `To4()` will determine it is an IPv4 address and miss the listening IPv6 socket. With this PR, we specify the IP family explicitly instead of trying to determine it from the IP address. Fixes #3306. (cherry picked from commit 5dcc369)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…on of incoming IPv6 sockets (elastic#12249) To determine the direction of a socket, we save the list of listening sockets and match non-listening sockets to them. If we find a match, the non-listening socket is `Incoming`, otherwise `Outgoing`. A problem occurs when matching an IPv6 socket listening on all interfaces (`::`) with an IPv6 socket that has an IPv4-mapped IPv6 address (e.g. `::ffff:127.0.0.1`). Golang's `To4()` will determine it is an IPv4 address and miss the listening IPv6 socket. With this PR, we specify the IP family explicitly instead of trying to determine it from the IP address. Fixes elastic#3306. (cherry picked from commit 01ca04b)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…ic#12248) (elastic#12250) To determine the direction of a socket, we save the list of listening sockets and match non-listening sockets to them. If we find a match, the non-listening socket is `Incoming`, otherwise `Outgoing`. A problem occurs when matching an IPv6 socket listening on all interfaces (`::`) with an IPv6 socket that has an IPv4-mapped IPv6 address (e.g. `::ffff:127.0.0.1`). Golang's `To4()` will determine it is an IPv4 address and miss the listening IPv6 socket. With this PR, we specify the IP family explicitly instead of trying to determine it from the IP address. Fixes elastic#3306. (cherry picked from commit 01ca04b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To determine the direction of a socket, we save the list of listening sockets and match non-listening sockets to them. If we find a match, the non-listening socket is
Incoming, otherwiseOutgoing.A problem occurs when matching an IPv6 socket listening on all interfaces (
::) with an IPv6 socket that has an IPv4-mapped IPv6 addresses (e.g.::ffff:127.0.0.1). Golang'sTo4()will determine it is an IPv4 address and miss the listening IPv6 socket.With this PR, we specify the IP family explicitly instead of trying to determine it from the IP address.
Fixes #3306.