Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timezone parsing in Rabbitmq logs #13879

Merged
merged 2 commits into from
Oct 4, 2019

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Oct 2, 2019

Similar to #13308, part of #13877.

@jsoriano jsoriano self-assigned this Oct 2, 2019
@jsoriano jsoriano marked this pull request as ready for review October 2, 2019 16:31
@jsoriano jsoriano requested a review from a team as a code owner October 2, 2019 16:31
@jsoriano jsoriano added Team:Integrations Label for the Integrations team [zube]: In Review labels Oct 2, 2019
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsoriano
Copy link
Member Author

jsoriano commented Oct 4, 2019

jenkins, test this again please

@jsoriano jsoriano merged commit 1ff1703 into elastic:master Oct 4, 2019
@jsoriano jsoriano deleted the fix-rabbitmq-timezone branch October 4, 2019 16:44
@zube zube bot added [zube]: Done and removed [zube]: Inbox labels Oct 4, 2019
@urso urso added the v7.5.0 label Oct 22, 2019
@leweafan
Copy link
Contributor

@jsoriano I see that ingest pipeline is using DATESTAMP which means date format dd-mm-yyyy or mm-dd-yyyy but it's not a case for test.log (2019-04-03 11:13:15.076) also I see that used timestamp format yy-mm-dd which also is not a case for DATESTAMP.
How is it possible that tests passed successful?

@jsoriano
Copy link
Member Author

@leweafan good catch. I have tried this pipeline, without removing the timestamp field, and I see that it works by chance, it is capturing the datestamp as:

"timestamp": "19-04-03 11:13:15.510"

Later, the date processor is interpreting 19 as 2019, but this is effectively error prone, and this will start failing at least in 2032. I tried changing the year in a date to 2032 and:

unexpected pipeline error: Text '2-04-03 11:13:15.076' could not be parsed at index 0

I will open an issue to fix this.

Thanks for reporting!

@jsoriano
Copy link
Member Author

Oh, you already opened an issue, I will comment there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants