Fix conditions for date processors without timezones #13883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
added
module
review
Filebeat
9 tasks
Some ingest processors use `event.timezone` field as timezone for the date processor. In the case the field is set, the date processor was being run twice, one without timezone and another one with timezone. If the field is not set, the date processor was ignoring error. Change date processor parameters so only one is run and both are consistent with error handling.
jsoriano
force-pushed
the
skip-date-processor-event-timezone
branch
from
ba0707d
to
fba5c6b
Compare
kaiyan-sheng
approved these changes
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some ingest processors use
event.timezonefield as timezone for thedate processor. In the case the field is set, the date processor was
being run twice, one without timezone and another one with timezone. If
the field is not set, the date processor was ignoring error. Change date
processor parameters so only one is run and both are consistent with
error handling.
More context about this change in #13367 (comment)
This has to be revisited also in some other modules, but they are the
ones affected by #13877 and it will be fixed all together.