-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metricbeat] change server_status_path default setting for nginx module #14099
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
jenkins, test this please |
Thank you for contributing @goku321, could you please add a changelog entry? You will also need to run |
Sure @exekias , will do 👍 |
Hi @goku321 thanks for contributing. This PR will also need a rebase/merge from master in order to let CI pass. |
Syncing with master
Hi @kaiyan-sheng I have synced this PR with master. Also, will add a changelog entry. Thanks for your patience |
jenkins, test this please |
I am struggling with |
Maybe try |
Thanks for the suggestion @kaiyan-sheng but still getting the same error ( |
Yeah unfortunately python2.7 is needed... |
Maybe this will help if you don't want to spend too much time on fixing python2.7:
|
Hi @goku321, could you rebase this PR by any chance and also I posted the change you need for fixing the breaking python ci test. |
@kaiyan-sheng sure, will do it by tomorrow |
Syncing with master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this change!
Changed default
server_status_path
tonginx_status
Fixes: #13806