Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Heartbeat][7.x] Fix excessive memory usage when parsing bodies (#15639) #15762

Merged
merged 1 commit into from
Jan 23, 2020
Merged

[Heartbeat][7.x] Fix excessive memory usage when parsing bodies (#15639) #15762

merged 1 commit into from
Jan 23, 2020

Conversation

andrewvc
Copy link
Contributor

  • [Heartbeat] Fix excessive memory usage when parsing bodies

In 7.5 we introduced a regression where we would allocate a 100MiB
buffer per HTTP request. This change fixes that to stream data instead.

@andrewvc
[Heartbeat] Fix excessive memory usage when parsing bodies (elastic#1…
a4ad41c 
…5639)

* [Heartbeat] Fix excessive memory usage when parsing bodies

In 7.5 we introduced a regression where we would allocate a 100MiB
buffer per HTTP request. This change fixes that to stream data instead.

(cherry picked from commit 080dedb)
@andrewvc andrewvc added backport Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team labels Jan 22, 2020
@andrewvc andrewvc requested a review from a team as a code owner January 22, 2020 23:19
@andrewvc andrewvc self-assigned this Jan 22, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (:uptime)

@andrewvc andrewvc requested a review from urso January 22, 2020 23:20
@andrewvc andrewvc changed the title [Heartbeat] Fix excessive memory usage when parsing bodies (#15639) [Heartbeat][7.x] Fix excessive memory usage when parsing bodies (#15639) Jan 22, 2020
@andrewvc andrewvc merged commit 758a1d7 into elastic:7.x Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urso urso urso approved these changes

Assignees

@andrewvc andrewvc

Labels
backport Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewvc @elasticmachine @urso