-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metricbeat] Change sqs metricset to use Average statistic method #16438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaiyan-sheng
added
bug
needs_backport
PR is waiting to be backported to other branches.
review
Team:Platforms
Label for the Integrations - Platforms team
labels
Feb 19, 2020
mtojek
approved these changes
Feb 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I admit that I had to go over the discuss thread to fully understand the issue. Ship it!
nit: fix is correct, but please re-export JSON files:
Error: failed to parse dashboard from module/aws/_meta/kibana/7/dashboard/Metricbeat-aws-sqs-overview.json: json: cannot unmarshal string into Go struct field .objects.attributes.kibanaSavedObjectMeta.searchSourceJSON of type struct { Index string "json:\"index\"" }
kaiyan-sheng
added
v7.7.0
and removed
needs_backport
PR is waiting to be backported to other branches.
labels
Feb 20, 2020
kaiyan-sheng
added a commit
that referenced
this pull request
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is to change sqs metricset to use Average statistic method instead of Sum when querying CloudWatch metrics.
Related Discuss Forum Issue: https://discuss.elastic.co/t/metricbeat-aws-module-dashboard-not-working-and-aws-sqs-messages-visible-multiplied-by-5
This PR also fixed SQS dashboard to show last bucket with
"drop_last_bucket":0
. This case, when Metricbeat first started, dashboard will not be empty.Why is it important?
Most of the metrics collected by CloudWatch regarding to SQS is more meaningful with average as statistic method. For example ApproximateAgeOfOldestMessage for the approximate age of the oldest non-deleted message in the queue, and ApproximateNumberOfMessagesVisible for the number of messages available for retrieval from the queue.
Screenshots
This is what I changed for each visualization in SQS dashboard to not drop the last bucket.