Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #16733 to 7.x: [Metricbeat] Rename tags to tags_filter for cloudwatch metricset #18660

Merged
merged 1 commit into from
May 20, 2020
Merged

Cherry-pick #16733 to 7.x: [Metricbeat] Rename tags to tags_filter for cloudwatch metricset #18660

merged 1 commit into from
May 20, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

Cherry-pick of PR #16733 to 7.x branch. Original message:

This PR is to deprecate tags in cloudwatch metricset config. This is replaced by tags_filter, which is a metricset level config parameter for all metricsets under aws module.

)

* Deprecate tags config parameter to use tags_filter instead for cloudwatch metricset

(cherry picked from commit 7e5e98c)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 20, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this May 20, 2020
@kaiyan-sheng kaiyan-sheng added Team:Platforms Label for the Integrations - Platforms team and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 20, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

Test stats 🧪

Test Results
Failed 0
Passed 478
Skipped 48
Total 526

Steps errors

Expand to view the steps failures

  • Name: Report to Codecov
    • Description: curl -sSLo codecov https://codecov.io/bash for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat do FILE="${i}/build/coverage/full.cov" if [ -f "${FILE}" ]; then bash codecov -f "${FILE}" fi done

    • Result: FAILURE

    • Duration: 2 min 22 sec

    • Start Time: 2020-05-20T14:26:27.948+0000

    • log

@kaiyan-sheng kaiyan-sheng merged commit 311ab02 into elastic:7.x May 20, 2020
@kaiyan-sheng kaiyan-sheng deleted the backport_16733_7.x branch May 20, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport review Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants