Cherry-pick #22074 to 7.10: Remove old TODO on kubernetes node update

[ChrsMark]

Cherry-pick of PR #22074 to 7.10 branch. Original message:

@exekias @vjsamuel is this TODO

beats/libbeat/autodiscover/providers/kubernetes/node.go

Line 108 in bcb4e0c

// TODO: figure out how to avoid stop starting when node status is periodically being updated by kubelet

still valid or should be removed after #19974?

[elasticmachine]

Pinging @elastic/integrations-platforms (Team:Platforms)

[botelastic]

This pull request doesn't have a Team:<team> label.

[elasticmachine]

💔 Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Build Cause: [Pull request #22155 opened]

• Start Time: 2020-10-26T15:59:30.935+0000

• Duration: 94 min 57 sec

Test stats 🧪

Test	Results
Failed	2
Passed	16307
Skipped	1369
Total	17678

Test errors

Expand to view the tests failures

• Name: Build&Test / x-pack/elastic-agent-build / TestRetriesOnFailures – application

  • Age: 1
  • Duration: 0
  • Error Details: Failed

• Name: Build&Test / x-pack/elastic-agent-build / TestRetriesOnFailures/When_the_gateway_fails_to_communicate_with_the_checkin_API_we_will_retry – application

  • Age: 1
  • Duration: 0
  • Error Details: Failed

Steps errors

Expand to view the steps failures

• Name: x-pack/elastic-agent-build - mage build test

  • Description: mage build test

  • Duration: 12 min 54 sec

  • Start Time: 2020-10-26T16:27:00.997+0000

  • log

Log output

Expand to view the last 100 lines of log output

[2020-10-26T17:32:24.588Z]   GitCommit:        8fba4e9a7d01810a393d5d25a3621dc101981175
[2020-10-26T17:32:24.588Z]  runc:
[2020-10-26T17:32:24.588Z]   Version:          1.0.0-rc10
[2020-10-26T17:32:24.588Z]   GitCommit:        dc9208a3303feef5b3839f4323d9beb36df0a9dd
[2020-10-26T17:32:24.588Z]  docker-init:
[2020-10-26T17:32:24.588Z]   Version:          0.18.0
[2020-10-26T17:32:24.588Z]   GitCommit:        fec3683
[2020-10-26T17:32:37.636Z] [INFO] unstashV2: JOB_GCS_BUCKET is set. bucket param got precedency instead.
[2020-10-26T17:32:37.657Z] [INFO] unstashV2: JOB_GCS_CREDENTIALS is set. credentialsId param got precedency instead.
[2020-10-26T17:32:37.722Z] [Google Cloud Storage Plugin] Found 1 files to download from pattern: gs://beats-ci-temp/Beats/beats/PR-22155-1/source/source.tgz
[2020-10-26T17:32:37.740Z] [Google Cloud Storage Plugin] Downloading: Beats/beats/PR-22155-1/source/source.tgz to local path: /var/lib/jenkins/workspace/Beats_beats_PR-22155/source.tgz
[2020-10-26T17:32:46.632Z] + tar --version
[2020-10-26T17:32:46.949Z] + tar -xpf source.tgz
[2020-10-26T17:32:59.591Z] + rm source.tgz
[2020-10-26T17:32:59.817Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats
[2020-10-26T17:32:59.850Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats/libbeat-stress-tests-1603729633488
[2020-10-26T17:32:59.957Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats/winlogbeat-crosscompile-1603729701134
[2020-10-26T17:33:00.064Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats/auditbeat-crosscompile-1603729718645
[2020-10-26T17:33:00.360Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats/x-pack-dockerlogbeat-build-1603729784509
[2020-10-26T17:33:00.476Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats/journalbeat-unitTest-1603729804873
[2020-10-26T17:33:00.581Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats/x-pack-functionbeat-build-1603729879580
[2020-10-26T17:33:00.696Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats/libbeat-crosscompile-1603729884385
[2020-10-26T17:33:00.807Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats/packetbeat-build-1603729996331
[2020-10-26T17:33:00.927Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats/metricbeat-unitTest-1603730115398
[2020-10-26T17:33:01.039Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats/x-pack-elastic-agent-windows-windows-2019-1603730131022
[2020-10-26T17:33:01.160Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats/auditbeat-windows-windows-2019-1603730160485
[2020-10-26T17:33:01.281Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats/auditbeat-build-1603730196681
[2020-10-26T17:33:01.401Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats/metricbeat-crosscompile-1603730203853
[2020-10-26T17:33:01.527Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats/heartbeat-build-1603730209215
[2020-10-26T17:33:01.642Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats/generator-metricbeat-test-1603730231170
[2020-10-26T17:33:01.755Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats/heartbeat-windows-windows-2019-1603730272328
[2020-10-26T17:33:01.867Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats/x-pack-auditbeat-windows-windows-2019-1603730297833
[2020-10-26T17:33:01.976Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats/generator-beat-test-1603730320855
[2020-10-26T17:33:02.090Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats/x-pack-winlogbeat-build-windows-2019-1603730326300
[2020-10-26T17:33:02.210Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats/x-pack-elastic-agent-build-1603730340593
[2020-10-26T17:33:02.322Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats/x-pack-functionbeat-windows-windows-2019-1603730352577
[2020-10-26T17:33:02.434Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats/x-pack-libbeat-build-1603730426973
[2020-10-26T17:33:02.553Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats/packetbeat-windows-windows-2019-1603730442328
[2020-10-26T17:33:02.677Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats/x-pack-auditbeat-build-1603730450372
[2020-10-26T17:33:02.809Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats/filebeat-windows-windows-2019-1603730450561
[2020-10-26T17:33:02.915Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats/winlogbeat-windows-windows-2019-1603730456526
[2020-10-26T17:33:03.020Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats/x-pack-filebeat-windows-windows-2019-1603730507816
[2020-10-26T17:33:03.134Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats/metricbeat-windows-windows-2019-1603730619254
[2020-10-26T17:33:03.312Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats/x-pack-metricbeat-windows-windows-2019-1603730702221
[2020-10-26T17:33:03.420Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats/filebeat-build-1603731175025
[2020-10-26T17:33:03.528Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats/libbeat-build-1603731378793
[2020-10-26T17:33:03.643Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats/metricbeat-goIntegTest-1603731560608
[2020-10-26T17:33:03.744Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats/metricbeat-pythonIntegTest-1603731644933
[2020-10-26T17:33:03.847Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats/x-pack-filebeat-build-1603731900855
[2020-10-26T17:33:03.947Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats/x-pack-metricbeat-build-1603733158190
[2020-10-26T17:33:04.376Z] + cat
[2020-10-26T17:33:04.376Z] + /usr/local/bin/runbld ./runbld-test-reports --job-name elastic+beats+pull-request
[2020-10-26T17:33:04.376Z] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
[2020-10-26T17:33:11.017Z] runbld>>> runbld started
[2020-10-26T17:33:11.017Z] runbld>>> 1.6.12/f45d832f2ba0aa2722ab4ec1fda8ad140f027f8b
[2020-10-26T17:33:12.402Z] runbld>>> The following profiles matched the job 'elastic+beats+pull-request' in order of occurrence in the config (last value wins).
[2020-10-26T17:33:12.402Z] runbld>>> Matches in the system config:
[2020-10-26T17:33:12.402Z] runbld>>> - Matched ^elastic\+beats
[2020-10-26T17:33:12.402Z] runbld>>> - Matched ^elastic\+beats\+pull-request
[2020-10-26T17:33:13.793Z] runbld>>> Debug logging enabled.
[2020-10-26T17:33:13.793Z] runbld>>> Storing result
[2020-10-26T17:33:13.793Z] runbld>>> Store result: created {:total 2, :successful 2, :failed 0} 1
[2020-10-26T17:33:13.793Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1597739501209/t/20201026173313-80C80F72
[2020-10-26T17:33:13.793Z] runbld>>> Adding system facts.
[2020-10-26T17:33:15.194Z] runbld>>> Adding vcs info for the latest commit:  145a1a1afa2b095218999fe5c2ab19cd5754013f
[2020-10-26T17:33:15.194Z] runbld>>> >>>>>>>>>>>> SCRIPT EXECUTION BEGIN >>>>>>>>>>>>
[2020-10-26T17:33:15.194Z] runbld>>> Adding /usr/lib/jvm/java-8-openjdk-amd64/bin to the path.
[2020-10-26T17:33:15.194Z] + echo 'Processing JUnit reports with runbld...'
[2020-10-26T17:33:15.194Z] Processing JUnit reports with runbld...
[2020-10-26T17:33:15.456Z] runbld>>> <<<<<<<<<<<< SCRIPT EXECUTION END <<<<<<<<<<<<
[2020-10-26T17:33:15.456Z] runbld>>> DURATION: 24ms
[2020-10-26T17:33:15.456Z] runbld>>> STDOUT: 40 bytes
[2020-10-26T17:33:15.456Z] runbld>>> STDERR: 49 bytes
[2020-10-26T17:33:15.456Z] runbld>>> WRAPPED PROCESS: SUCCESS (0)
[2020-10-26T17:33:15.456Z] runbld>>> Searching for build metadata in /var/lib/jenkins/workspace/Beats_beats_PR-22155
[2020-10-26T17:33:16.401Z] runbld>>> Storing build metadata: 
[2020-10-26T17:33:16.401Z] runbld>>> Adding test report.
[2020-10-26T17:33:16.401Z] runbld>>> Searching for junit test output files with the pattern: TEST-.*\.xml$ in: /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats
[2020-10-26T17:33:17.348Z] runbld>>> Found 123 test output files
[2020-10-26T17:33:19.001Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats/metricbeat-goIntegTest-1603731560608/metricbeat/build/TEST-go-integration-windows.xml
[2020-10-26T17:33:19.001Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats/metricbeat-goIntegTest-1603731560608/metricbeat/build/TEST-go-integration-graphite.xml
[2020-10-26T17:33:19.263Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats/x-pack-metricbeat-build-1603733158190/x-pack/metricbeat/build/TEST-go-integration-tomcat.xml
[2020-10-26T17:33:19.263Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats/x-pack-metricbeat-build-1603733158190/x-pack/metricbeat/build/TEST-go-integration-istio.xml
[2020-10-26T17:33:19.263Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats/x-pack-metricbeat-build-1603733158190/x-pack/metricbeat/build/TEST-go-integration-openmetrics.xml
[2020-10-26T17:33:19.263Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats/x-pack-metricbeat-build-1603733158190/x-pack/metricbeat/build/TEST-go-integration-activemq.xml
[2020-10-26T17:33:19.263Z] runbld>>> No testsuite node found in /var/lib/jenkins/workspace/Beats_beats_PR-22155/src/github.com/elastic/beats/x-pack-metricbeat-build-1603733158190/x-pack/metricbeat/build/TEST-go-integration-iis.xml
[2020-10-26T17:33:20.663Z] runbld>>> Test output logs contained: Errors: 0 Failures: 2 Tests: 17678 Skipped: 1088
[2020-10-26T17:33:20.925Z] runbld>>> Storing result
[2020-10-26T17:33:20.925Z] runbld>>> FAILURES: 2
[2020-10-26T17:33:21.500Z] runbld>>> Store result: updated {:total 2, :successful 2, :failed 0} 2
[2020-10-26T17:33:21.500Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1597739501209/t/20201026173313-80C80F72
[2020-10-26T17:33:21.500Z] runbld>>> Email notification disabled by environment variable.
[2020-10-26T17:33:21.500Z] runbld>>> Slack notification disabled by environment variable.
[2020-10-26T17:33:27.090Z] Running on Jenkins in /var/lib/jenkins/workspace/Beats_beats_PR-22155
[2020-10-26T17:33:27.185Z] [INFO] getVaultSecret: Getting secrets
[2020-10-26T17:33:27.255Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-10-26T17:33:28.301Z] + chmod 755 generate-build-data.sh
[2020-10-26T17:33:28.301Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-22155/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-22155/runs/1 FAILURE 5637096
[2020-10-26T17:33:28.301Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-22155/runs/1/steps/?limit=10000 -o steps-info.json
[2020-10-26T17:33:30.784Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-22155/runs/1/tests/?status=FAILED -o tests-errors.json