Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #22291 to 7.x: [Filebeat] Refactor Suricata pipeline to use Ingest Node more #22453

Merged
merged 1 commit into from
Nov 6, 2020

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Nov 5, 2020

Cherry-pick of PR #22291 to 7.x branch. Original message:

What does this PR do?

Refactor the Suricata module pipeline to use Ingest Node more. I moved most processing from Beat processors to Ingest Node. I created a DNS and TLS pipeline to house all of the processing for those protocols respectively.

Other changes

  • Added DNS response IPs to related.ip.
  • Some DNS events were missing dns.header_flags.

Why is it important?

Hopefully by reducing processing in Filebeat this week increase the throughput of the Suricata module. Testing to follow.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

…c#22291)

Refactor the Suricata module pipeline to use Ingest Node more. I moved most
processing from Beat processors to Ingest Node. I created a DNS and TLS
pipeline to house all of the processing for those protocols respectively.

Other changes
- Added DNS response IPs to `related.ip`.
- Some DNS events were missing `dns.header_flags`.


(cherry picked from commit 2fe9e2a)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 5, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 5, 2020
@botelastic
Copy link

botelastic bot commented Nov 5, 2020

This pull request doesn't have a Team:<team> label.

Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Collaborator

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 1948
Skipped 259
Total 2207

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22453 opened]

  • Start Time: 2020-11-05T19:54:03.681+0000

  • Duration: 49 min 57 sec

Test stats 🧪

Test Results
Failed 0
Passed 1948
Skipped 259
Total 2207

@andrewkroh andrewkroh merged commit 668ceab into elastic:7.x Nov 6, 2020
@zube zube bot removed the [zube]: Done label Feb 5, 2021
@andrewkroh andrewkroh deleted the backport_22291_7.x branch January 14, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants