Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #23035 to 7.x: [Filebeat] Add regenerated rsa2elk modules with subdomain processors #23119

Merged
merged 1 commit into from
Dec 14, 2020
Merged

Cherry-pick #23035 to 7.x: [Filebeat] Add regenerated rsa2elk modules with subdomain processors #23119

merged 1 commit into from
Dec 14, 2020

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented Dec 14, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #23035 to 7.x branch. Original message:

What does this PR do?

This imports regenerated rsa2elk modules based off of the changes in adriansr/nwdevice2filebeat#10

The changes allow us to fill in registered_domain and subdomain every place we have those fields available in ECS.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@adriansr
[Filebeat] Add regenerated rsa2elk modules with subdomain processors (e…
b388335 
…lastic#23035)

Changed rsa2elk modules with registered_domain and subdomain every place we have those fields available in ECS.

(cherry picked from commit 2988c49)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 14, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 14, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23119 opened

  • Start Time: 2020-12-14T18:33:19.334+0000

  • Duration: 51 min 4 sec

Test stats 🧪

Test Results
Failed 0
Passed 2417
Skipped 261
Total 2678

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2417
Skipped 261
Total 2678

@adriansr adriansr merged commit 95a83b0 into elastic:7.x Dec 14, 2020
@zube zube bot removed the [zube]: Done label Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewstucki andrewstucki andrewstucki approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adriansr @elasticmachine @andrewstucki