Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Heartbeat] Enable script processor #23229

Merged
merged 2 commits into from
Jan 29, 2021

Conversation

andrewvc
Copy link
Contributor

@andrewvc andrewvc commented Dec 21, 2020

Enables the script processor for heartbeat. This is an opt-in processor, but there's really never been a concrete need for that. This fixes #22788 .

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Add a script section to the processors block, it will work!

Use cases

Mostly useful for situations where people want to apply novel complex logic. See #22788

@andrewvc andrewvc added enhancement Team:obs-ds-hosted-services Label for the Observability Hosted Services team v7.12.0 labels Dec 21, 2020
@andrewvc andrewvc requested a review from a team as a code owner December 21, 2020 22:49
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 21, 2020
@andrewvc andrewvc changed the title Enable script processor [Heartbeat] Enable script processor Dec 21, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 21, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23229 updated

  • Start Time: 2020-12-21T22:53:53.323+0000

  • Duration: 22 min 42 sec

Test stats 🧪

Test Results
Failed 0
Passed 953
Skipped 13
Total 966

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 953
Skipped 13
Total 966

@botelastic
Copy link

botelastic bot commented Jan 20, 2021

Hi!
We just realized that we haven't looked into this PR in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it in as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1.
Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Jan 20, 2021
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@botelastic botelastic bot removed the Stalled label Jan 29, 2021
@andrewvc andrewvc merged commit b89e5d6 into elastic:master Jan 29, 2021
@andrewvc andrewvc deleted the enable-script-processor branch January 29, 2021 21:33
andrewvc added a commit to andrewvc/beats that referenced this pull request Jan 29, 2021
Enables the script processor for heartbeat. This is an opt-in processor, but there's really never been a concrete need for that. This fixes elastic#22788 .

(cherry picked from commit b89e5d6)
andrewvc added a commit that referenced this pull request Jan 29, 2021
Enables the script processor for heartbeat. This is an opt-in processor, but there's really never been a concrete need for that. This fixes #22788 .

(cherry picked from commit b89e5d6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

script processor support for Heartbeat
3 participants