Cherry-pick #23236 to 7.11: [Filebeat] Improve Suricata error handling #23807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
botelastic
bot
added
needs_team
This fixes several errors processing EVE logs. Fix null dereference of suricata.eve.http.status. Even for http events it can be null. Remove unused field mapping for suricata.eve.flow.end Improve error.message details in pipeline on_failure handlers. Add tags to script processors to improve error messages. Rename suricata.eve.http.http_port to url.port. Add remove processor to on_failure handler to remove any alias field to prevent indexing errors. Ignore errors parsing TLS version. The pipeline got a value of "UNDETERMINED" that caused an error. Ignore errors parsing TLS subject/issuer DNs with kv. If a value contain the value_split string like "Nutanix, Inc." it can fail. (cherry picked from commit 11c5367)
andrewkroh
force-pushed
the
backport_23236_7.11
branch
from
4a6597b
to
af26037
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errors
Expand to view the steps failures
|
| Test | Results |
|---|---|
| Failed | 0 |
| Passed | 12745 |
| Skipped | 2047 |
| Total | 14792 |
leehinman
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #23236 to 7.11 branch. Original message:
What does this PR do?
This fixes several errors processing EVE logs.
Why is it important?
Errors were preventing
removeprocessors from running. This left concrete values in the events for fields that are mapped as alias. Those events were rejected.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.