Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #23772 to 7.x: [Filebeat] Add Zeek Signatures fileset #24078

Merged
merged 1 commit into from
Feb 17, 2021
Merged

Cherry-pick #23772 to 7.x: [Filebeat] Add Zeek Signatures fileset #24078

merged 1 commit into from
Feb 17, 2021

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Feb 16, 2021 •
edited by zube bot
Loading

Cherry-pick of PR #23772 to 7.x branch. Original message:

What does this PR do?

Add the Signature fileset to the Zeek module for Filbeat.

Why is it important?

Its one of the last zeek logs that isn't parsed by Filebeat currently.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 16, 2021
@legoguy1000 @andrewkroh
Add Zeek Signatures (elastic#23772)
68bddb5 
Add the Signature fileset to the Zeek module for Filbeat.

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
(cherry picked from commit e332d9d)
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24078 updated

  • Start Time: 2021-02-17T00:00:24.432+0000

  • Duration: 50 min 42 sec

  • Commit: 68bddb5

Test stats 🧪

Test Results
Failed 0
Passed 13008
Skipped 2061
Total 15069

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 13008
Skipped 2061
Total 15069

P1llus
P1llus approved these changes Feb 17, 2021
View reviewed changes
Copy link
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@andrewkroh andrewkroh merged commit 5f1bf05 into elastic:7.x Feb 17, 2021
@zube zube bot removed the [zube]: Done label May 18, 2021
@andrewkroh andrewkroh deleted the backport_23772_7.x branch January 14, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P1llus P1llus P1llus approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewkroh @elasticmachine @P1llus @legoguy1000