Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust host fields in Metricbeat to use ECS 1.9.0 field names #24312

Merged
merged 19 commits into from
May 3, 2021
Merged

Adjust host fields in Metricbeat to use ECS 1.9.0 field names #24312

merged 19 commits into from
May 3, 2021

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Mar 3, 2021

What does this PR do?

With additional host fields get into ECS 1.9.0, we need to adjust the fields we added into Metricbeat to adopt the ECS field names.

  • system module
  • aws module
  • azure module
  • gcp module

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 3, 2021
@kaiyan-sheng kaiyan-sheng self-assigned this Mar 3, 2021
@kaiyan-sheng kaiyan-sheng added breaking change needs_backport PR is waiting to be backported to other branches. Team:Integrations Label for the Integrations team labels Mar 3, 2021
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 3, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 3, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24312 updated

  • Start Time: 2021-04-27T19:29:34.729+0000

  • Duration: 168 min 40 sec

  • Commit: 271b96b

Test stats 🧪

Test Results
Failed 0
Passed 46637
Skipped 5129
Total 51766

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 46637
Skipped 5129
Total 51766

@kaiyan-sheng
Copy link
Contributor Author

/test

@kaiyan-sheng kaiyan-sheng marked this pull request as ready for review April 27, 2021 19:16
@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner April 27, 2021 19:16
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@kaiyan-sheng kaiyan-sheng changed the title Bump ecs to 1.9.0 and adjust host fields in Metricbeat Adjust host fields in Metricbeat to use ECS 1.9.0 field names Apr 28, 2021
@kaiyan-sheng kaiyan-sheng requested review from sayden, narph and fearful-symmetry and removed request for a team April 29, 2021 03:05
@narph
Copy link
Contributor

narph commented May 3, 2021

@kaiyan-sheng , have you checked if these changes affected any of the dashboards? I have a feeling we are using some of the fields in the visualizations?

Copy link
Contributor

@sayden sayden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! But I haven't checked the dashboards though

@kaiyan-sheng
Copy link
Contributor Author

Thanks @sayden @narph ! These fields are brand new actually, we added them when we started the inventory schema work. So they are not used in any dashboards or visualizations yet. They will be adopted in kibana metrics UI soon and that's why I want to get this in soon so the UI doesn't have to make the naming change again.

@kaiyan-sheng kaiyan-sheng merged commit dc8992b into elastic:master May 3, 2021
@kaiyan-sheng kaiyan-sheng deleted the use_ecs_host_fields branch May 3, 2021 15:37
@kaiyan-sheng kaiyan-sheng added v7.14.0 and removed needs_backport PR is waiting to be backported to other branches. labels May 3, 2021
kaiyan-sheng added a commit that referenced this pull request May 5, 2021
…S 1.9.0 field names (#25501)

(cherry picked from commit dc8992b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants