-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filebeat] Remove space from field sophos.xg.trans_src_ ip
#25250
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Trends 🧪❕ Flaky test reportNo test was executed to be analysed. |
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
48690b8
to
3a62c18
Compare
This pull request is now in conflicts. Could you fix it? 🙏
|
3a62c18
to
fccc282
Compare
@andrewkroh Can you take a look at this one too. Should be a quick one. |
This pull request is now in conflicts. Could you fix it? 🙏
|
fccc282
to
153f9ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will await CI to pass then merge.
run tests |
Could you backport this to 7.x, 7.12 and 7.13 branches @legoguy1000 ? |
…stic#25250) (cherry picked from commit a5079ef)
…stic#25250) (cherry picked from commit a5079ef)
…stic#25250) (cherry picked from commit a5079ef)
Sync fix from elastic/beats#25250.
Remove space from sophos.xg.trans_src_ip field name in mapping. Sync fix from elastic/beats#25250. Do not modify event.original. Populate `url.*` fields based on `sophos.xg.url`. Rename `sophos.xg.reason` to `event.reason` (ECS). Normalize all `sophos.xg.*` keys to lowercase. Lowercase `network.transport` as per ECS. Format `source.mac` and `destination.mac` as per ECS. Add Sophos Firewall 18.5 log samples taken from documentation. Set the `event.code` from the message ID (and remove `sophos.xg.messageid`). Consolidate geoip enrichment Consolidate related.ip processors Consolidate lowercase network.transport/protocol Consolidate related.user processing Consolidate related.hash Consolidate network.{bytes,packets} calculations Add network.community_id Add {url,source,destination}.domain to related.hosts Set event.duration (ns) for WAF events using reponsetime (us) Remove client/server mappings. This was a large amount of duplication causing increased event sizes. Add reference link to xg syslog formats Anti-Virus - Set `destination.domain` from `sophos.xg.dstdomain` in anti-virus log. - Use `sophos.xg.dst_domainname` to set `destination.domain` for Anti-Virus SMTP events. - Use `sophos.xg.src_domainname` to set `source.domain` for Anti-Virus SMTP events. - Set `network.protocol` for anti-virus logs. Anti-Spam - Set `network.protocol` for anti-spam logs. Content Filtering - Set `network.protocol` for Content Filtering. Use the URL scheme to derive the protocol. Sandstorm - Set `file.name` for Sandstorm events (there was a typo in the if condition). - Set `url.domain`, `destination.domain`, and `destination.ip` for Sandstorm web events. - Handle sha256 Sandstorm file hashes. In 17.5 and earlier the sha1sum contained the sha1 checksum of the file being analyzed. In 18.0 and later the sha1sum contains the sha256 checksum of the file. System Health - Convert `sophos.xg.collisions`, `sophos.xg.receiveddrops`, and `sophos.xg.transmitteddrops` to float in document `_source`. Wireless Protection Change `sophos.xg.clients_conn_ssid` to a long in the mapping. * Update files [git-generate] cd packages/sophos elastic-package format elastic-package build elastic-package test pipeline -g * Add changelog * Remove null-safe operator when accessing ctx Replaces `ctx?.` with `ctx.` in all of the sophos.xg pipelines. * Sort ecs.yml and fields.yml by name
… `sophos.xg.trans_src_ ip` (elastic#25525) * elastic#25154: Remove space from field `sophos.xg.trans_src_ ip` (elastic#25250) (cherry picked from commit 0d955a0) * Update CHANGELOG.next.asciidoc Co-authored-by: Marius Iversen <marius.iversen@elastic.co>
What does this PR do?
Removes the space in
sophos.xg.trans_src_ ip
->sophos.xg.trans_src_ip
Why is it important?
Field has an invalid space
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs