Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for azure billing dashboard #25554

Merged
merged 2 commits into from
May 6, 2021
Merged

Fix for azure billing dashboard #25554

merged 2 commits into from
May 6, 2021

Conversation

narph
Copy link
Contributor

@narph narph commented May 5, 2021

What does this PR do?

Fix for azure billing dashboard.
Also small fix for the storage dashboard.

Why is it important?

azure.resource.name was removed by mistake in billing
Fix for azure billing dashboard.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 5, 2021
@narph narph self-assigned this May 5, 2021
@narph narph added the Team:Integrations Label for the Integrations team label May 5, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 5, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 5, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #25554 updated

  • Start Time: 2021-05-05T13:23:14.873+0000

  • Duration: 134 min 39 sec

  • Commit: f0de517

Test stats 🧪

Test Results
Failed 0
Passed 8772
Skipped 2478
Total 11250

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 8772
Skipped 2478
Total 11250

ChrsMark
ChrsMark approved these changes May 5, 2021
View reviewed changes
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@narph do we know what versions it affects so as to also consider backporting this to these versions too?

@narph narph merged commit 5e084a7 into elastic:master May 6, 2021
@narph
Copy link
Contributor Author

narph commented May 6, 2021 •
edited
Loading

LGTM!

@narph do we know what versions it affects so as to also consider backporting this to these versions too?

we do, backported already

@narph narph mentioned this pull request May 6, 2021
Merged
6 tasks
@narph narph added the v7.12.2 label May 6, 2021
narph added a commit to narph/beats that referenced this pull request May 6, 2021
@narph
Fix for azure billing dashboard (elastic#25554)
9d7d953 
* add field back

* changelog

(cherry picked from commit 5e084a7)
@narph narph mentioned this pull request May 6, 2021
Merged
6 tasks
@narph narph added the v7.14.0 label May 6, 2021
narph added a commit to narph/beats that referenced this pull request May 6, 2021
@narph
Fix for azure billing dashboard (elastic#25554)
87c4ad3 
* add field back

* changelog

(cherry picked from commit 5e084a7)
@narph narph mentioned this pull request May 6, 2021
Merged
6 tasks
narph added a commit to narph/beats that referenced this pull request May 6, 2021
@narph
Fix for azure billing dashboard (elastic#25554)
c65baf5 
* add field back

* changelog

(cherry picked from commit 5e084a7)
@narph narph added the v7.13.0 label May 6, 2021
narph added a commit that referenced this pull request May 6, 2021
@narph
Fix for azure billing dashboard (#25554) (#25579)
3784662 
* add field back

* changelog

(cherry picked from commit 5e084a7)
narph added a commit that referenced this pull request May 6, 2021
@narph
Cherry-pick #25554 to 7.12: Fix for azure billing dashboard (#25578)
ad30ff8 
* Fix for azure billing dashboard (#25554)

* add field back

* changelog

(cherry picked from commit 5e084a7)

* fix changelog
narph added a commit that referenced this pull request May 11, 2021
@narph
Fix for azure billing dashboard (#25554) (#25580)
23c7f15 
* add field back

* changelog

(cherry picked from commit 5e084a7)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@narph
Cherry-pick elastic#25554 to 7.12: Fix for azure billing dashboard (e…
e66b62a 
…lastic#25578)

* Fix for azure billing dashboard (elastic#25554)

* add field back

* changelog

(cherry picked from commit 9c08a31)

* fix changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

Assignees

@narph narph

Labels
Team:Integrations Label for the Integrations team v7.12.2 v7.13.0 v7.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Visualization not working on Azure billing dashboard
3 participants
@narph @elasticmachine @ChrsMark