-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Heartbeat] Cleanup docker install / always add playwright deps #32122
Merged
Merged
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
60771e7
[Heartbeat] Cleanup docker install / always add playwright deps
andrewvc a666855
More improvements
andrewvc 021d2e8
Remove unused agent dockerfile
andrewvc 92eaea8
Remove docker indentation
andrewvc dafc738
Remove empty RUN
andrewvc 89e907f
Fix indent
andrewvc 03e987d
Merge branch 'main' into add-wayland-client
mergify[bot] 06af3e8
Remove agent related package spec items
andrewvc fcfb419
Merge remote-tracking branch 'origin/main' into add-wayland-client
andrewvc 3c872a0
Merge remote-tracking branch 'andrewvc/add-wayland-client' into add-w…
andrewvc cc108bf
Merge branch 'main' into add-wayland-client
mergify[bot] 2dd8d7a
Merge branch 'main' into add-wayland-client
mergify[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
235 changes: 0 additions & 235 deletions
235
dev-tools/packaging/templates/docker/Dockerfile.elastic-agent.tmpl
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
- type: browser | ||
enabled: true | ||
id: cg-test-inl | ||
name: CG TESTINLINE | ||
data_stream.namespace: my-namespace | ||
source: | ||
inline: | ||
script: | ||
step("load homepage", async () => { | ||
await page.goto('https://www.elastic.co'); | ||
}); | ||
step("hover over products menu", async () => { | ||
await page.hover('css=[data-nav-item=products]'); | ||
}); | ||
step("failme", async () => { | ||
await page.hhover('css=[data-nav-item=products]'); | ||
}); | ||
schedule: "@every 1m" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is going to pull in lots of dependencies not related to chromium browser which is the only browser we support right now. Did we check the before/after image size with this change?
The command needs to be changed to
to be able to install only dependencies related to the chromium browser. The manual deps list was caerefully crafted for chromium only deps.