Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] Add Cloudflare R2 to provider list #32620

Merged
merged 3 commits into from
Aug 23, 2022

Conversation

legoguy1000
Copy link
Contributor

What does this PR do?

Now that Cloudflare R2 is out of closed beta, this adds their domain to the provider list to automatically detect and set the provider field.

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@legoguy1000 legoguy1000 requested a review from a team as a code owner August 7, 2022 14:28
@legoguy1000 legoguy1000 requested review from rdner and cmacknz and removed request for a team August 7, 2022 14:28
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 7, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 7, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-08T13:07:37.447+0000

  • Duration: 132 min 16 sec

Test stats 🧪

Test Results
Failed 0
Passed 4346
Skipped 338
Total 4684

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@cmacknz
Copy link
Member

cmacknz commented Aug 8, 2022

/test

@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 8, 2022
@cmacknz
Copy link
Member

cmacknz commented Aug 8, 2022

The S3 input doesn't have a codeowner listed, and I see changes from both cloud monitoring and SEI in the history. Requesting review from those teams, and we should clarify who the codeowner for this module should be if we can.

@mergify
Copy link
Contributor

mergify bot commented Aug 16, 2022

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @legoguy1000? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)
    To fixup this pull request, you need to add the backport labels for the needed
    branches, such as:
  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@rdner rdner removed their request for review August 18, 2022 07:10
@legoguy1000
Copy link
Contributor Author

Can this be merged?

@cmacknz cmacknz requested a review from a team August 23, 2022 12:48
@cmacknz
Copy link
Member

cmacknz commented Aug 23, 2022

Can someone from @elastic/obs-cloud-monitoring approve if they want to support this?

Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmacknz cmacknz merged commit 5922311 into elastic:main Aug 23, 2022
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
* Add Cloudflare R2 to provider list in AWS S3 input

* update unit tests

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants