-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pagetypeinfo behavior #39985
Fix pagetypeinfo behavior #39985
Conversation
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
This pull request is now in conflicts. Could you fix it? 🙏
|
Proposed commit message
closes #32026
So, the linux kernel will truncate page counts over 100k:
https://github.com/torvalds/linux/blob/e5b3efbe1ab1793bb49ae07d56d0973267e65112/mm/vmstat.c#L1521-L1528
We weren't handling this previously, so the metricset would just error out on the string
>100000
, as it didn't match the provided regex.This fixes that, and also adds a log line and bit of documentation to clarify how it works.
As the attached issue notes, this is a bit of a hard problem to solve "properly" as attempting to get creative and supplement data from
/proc/buddyinfo
instead will almost certainly result in misaligned data.Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.