x-pack/filebeat/input/cel: enhance error status reporting in error conditions #40083
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
enhancement
Filebeat
botelastic
bot
added
needs_team
…nditions We currently update the input status for single object events, but the error message held by the event is not reported via the UI. We have that value available, so use it to report the error, but do not include any other parts of the state as it may leak secrets.
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
4 tasks
andrewkroh
reviewed
Jul 3, 2024
| @@ -134,7 +134,7 @@ After completion of a program's execution it should return a single object with | |||
| ---- | |||
|
|
|||
| <1> The `events` field must be present, but may be empty or null. If it is not empty, it must only have objects as elements. | |||
| The field should be an array, but in the case of an error condition in the CEL program it is acceptable to return a single object instead of an array; this will will be wrapped as an array for publication and an error will be logged. | |||
| The field should be an array, but in the case of an error condition in the CEL program it is acceptable to return a single object instead of an array; this will will be wrapped as an array for publication and an error will be logged. If the single object contains a key, "error", the error value will be used to update the status of the input to report to Elastic Agent. This can be used to more rapidly respond to API failures. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
We currently update the input status for single object events, but the error message held by the event is not reported via the UI. We have that value available, so use it to report the error, but do not include any other parts of the state as it may leak secrets.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs